Fixing when keyword recommender in recursive patterns branch #2#30870
Conversation
| }"); | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.KeywordRecommending)] | ||
| public async Task TestForSwitchCase_SemanticCheck_AfterTypeAliasAndFieldConstantVar() => |
There was a problem hiding this comment.
This is not new behavior, it worked before the tests were skipped. Just adding an extra test case.
| }"); | ||
|
|
||
| [Fact(Skip = "https://github.com/dotnet/roslyn/issues/30848"), Trait(Traits.Feature, Traits.Features.KeywordRecommending)] | ||
| [Fact, Trait(Traits.Feature, Traits.Features.KeywordRecommending)] |
There was a problem hiding this comment.
This is not new behavior, it worked before the tests were skipped. Just adding an extra test case because things that used to be handled by one code path are now split into 2 branches, so I'm doing this to preserve code coverage.
|
@dpoeschl Would you please review this? |
src/EditorFeatures/CSharpTest2/Recommendations/WhenKeywordRecommenderTests.cs
Outdated
Show resolved
Hide resolved
|
PR easier to review as: https://github.com/dotnet/roslyn/pull/30870/files?w=1 due to indentation changes. |
| if (!(expression is TypeSyntax typeSyntax)) | ||
| bool isVar; | ||
| ImmutableArray<ISymbol> symbols; |
There was a problem hiding this comment.
i think it woudl be worth documenting these.
src/Features/CSharp/Portable/Completion/KeywordRecommenders/WhenKeywordRecommender.cs
Show resolved
Hide resolved
| bool isVar; | ||
| ImmutableArray<ISymbol> symbols; | ||
|
|
||
| if (nodeOrToken.IsNode) |
There was a problem hiding this comment.
i think it woudl be worth documenting which cases each part of the if is trying to handle.
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. But would prefer style be consistent with teh rest of the IDE, as well as some explanatory comments for the different cases being handle.d THanks!
|
@jinujoseph can this get an IDE buddy? Thanks! |
jinujoseph
added
Area-IDE
Community
|
retest windows_debug_vs-integration_prtest please |
|
@Neme12 Thank you!!!!! |
6 participants
Fixes #30848
cc @gafter