Improve undo stack titles for suggestions applied via light bulb#2823
Merged
heejaechang merged 1 commit intodotnet:masterfrom May 19, 2015
Merged
Conversation
This change introduces a workspace service that can be used to register the display strings that should be displayed in VS's undo stack for each change applied using light bulb. The string displayed in the undo stack is currently identical to the one displayed in the light bulb menu. Fixes dotnet#273
Contributor
Author
|
@heejaechang @srivatsn @mavasani @tmeschter @jmarolf Could you please take a look? |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Nit: Consider moving text and the if (text != null) below into the if (!changedFiles.Skip(1).Any()) body, since text isn't needed later and it might make it easier to see that this ``if` has no side effects.
Contributor
|
@shyamnamboodiripad @dpoeschl @jmarolf I think most of comments are small ones, so I will merge this PR and open an issue to Shaym to take a look at the PR feedback once he comes back and he can decide whether he will address the issues. is it sound good? |
Contributor
|
@heejaechang sounds good. |
heejaechang
added a commit
that referenced
this pull request
May 19, 2015
Improve undo stack titles for suggestions applied via light bulb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a workspace service that can be used to register the display strings that should be displayed in VS's undo stack for each change applied using light bulb. The string displayed in the undo stack is currently identical to the one displayed in the light bulb menu.
Fixes #273