Add NewLine option support to formatter#2417
Merged
mattwar merged 2 commits intodotnet:masterfrom May 1, 2015
mattwar:Bug202
Merged
Add NewLine option support to formatter#2417mattwar merged 2 commits intodotnet:masterfrom mattwar:Bug202
mattwar merged 2 commits intodotnet:masterfrom
mattwar:Bug202
Conversation
Contributor
|
The change as such looks good. There are some complex cases. For eg, in CurlyBraceCompletionSession, which returns We might also have to replace those instances with what the user desires. This is just one example. There will be more cases. |
Contributor
Author
|
My change does not add any new formatter behavior. It just changes the kinds of new lines it adds, when it adds them. |
Contributor
Author
|
@basoundr .. The caller is not expected to do trivia replacement. That's just the test forcing the new lines to be added. Normally only specific conditions, like alignment, cause the formatter to add new lines. For VB, it never does unless there is elastic trivia. |
Contributor
|
👍 |
Member
|
👍 from me too, once the test failures are figured out. |
mattwar
added a commit
that referenced
this pull request
May 1, 2015
Add NewLine option support to formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202
@basoundr @Pilchie @heejaechang please review