Skip to content

Adds NewLinesForBracesInProperties option.#232

Closed
mkrueger wants to merge 1 commit intodotnet:masterfrom
mkrueger:issue84
Closed

Adds NewLinesForBracesInProperties option.#232
mkrueger wants to merge 1 commit intodotnet:masterfrom
mkrueger:issue84

Conversation

@mkrueger
Copy link
Contributor

@mkrueger mkrueger commented Feb 4, 2015

Fixes Issue #84.

Just a possible way of handling the formatting. (Howver unit tests are missing and should be added)

@theoy theoy added Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. Enhancement labels Feb 5, 2015
@pharring
Copy link
Contributor

@dotnet-bot retest this, please.
@DustinCampbell @Pilchie, @dpoeschl does this look like something we'd accept?
If so, @mkrueger, it needs unit tests.

@mkrueger
Copy link
Contributor Author

The problem is that I can't run roslyn from inside md :/.

Treat that as proposal.

@sharwell
Copy link
Contributor

I would think it also needs to include a corresponding change to NewLinesViewModel.cs and a few other places?

@DustinCampbell
Copy link
Member

@pharring This is probably something we'd accept. We've chatted with @mkrueger about this particular option already.

@sharwell You're right. I'm comfortable with having some formatting options in the workspace layer that aren't threaded through to the IDE, but this one probably should be.

@Pilchie
Copy link
Member

Pilchie commented Mar 31, 2015

@mkrueger - what do you think - can you add some tests for this?

@mkrueger
Copy link
Contributor Author

If you can make monodevelop loading the project + the ms tests :/.

ATM I have no way running it.

@Pilchie
Copy link
Member

Pilchie commented Mar 31, 2015

We don't have any mstest based tests, we use xunit. You should be able to install the xunit.runners package (done as part of MSBuild BuildAndTest.proj) and then use packages\xunit.runners.2.0.0-alpha-build2576\tools\xunit.console.x86.exe to run the tests.

(Also spoke to @jaredpar - we just just restore the runners package directly instead of waiting for you to run MSBuild BuildAndTest.pro)

@mkrueger
Copy link
Contributor Author

I'll look at it.

UPDATE: I still can't load the roslyn project with monodevelop - will try again after project system changes.

@gafter
Copy link
Member

gafter commented Jun 5, 2015

Note that there is no contributor agreement for this PR. It is also quite stale.

@mkrueger
Copy link
Contributor Author

mkrueger commented Jun 6, 2015

We still have problems with the roslyn project on monodevelop :/ - as said regard that as proposal.

@mkrueger mkrueger closed this Jun 22, 2015
@mkrueger mkrueger deleted the issue84 branch June 22, 2015 09:09
dibarbet pushed a commit to dibarbet/roslyn that referenced this pull request Nov 21, 2025
Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.1.1 to 8.0.0.
- [Release notes](https://github.com/dotnet/sourcelink/releases)
- [Commits](dotnet/sourcelink@1.1.1...8.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.SourceLink.GitHub
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants