Expose a public API for building RQNames#2274
Merged
Pilchie merged 2 commits intodotnet:masterfrom Apr 29, 2015
Merged
Conversation
Member
Author
Contributor
|
The type should be called RQName, and the method should be called Create or From. |
* Rename RQNameService to RQName and make public. * Rename TryBuildForPublicApi to From and have it return null. * Remove TryBuild, since we *only* build RQNames for public Api's now. * Clean up implementation to not pass flag around for buildForPublicApi * Remove RQDynamicType * Create a singleton for System.Object. * Add a comment explaining why we erase dynamic. Fixes dotnet#55.
Pilchie
force-pushed
the
PublicRQNameBuilder
branch
from
fd24765 to
4f7cfc3
Compare
Member
Author
|
Thanks! Renamed There is no API that converts back, because we don't ever take RQNames as input - we just give them out when we are doing rename/go to definition. |
Member
Author
|
Not saying we couldn't/shouldn't add a method to go back to |
Contributor
|
👍 |
Contributor
|
👍 |
Pilchie
force-pushed
the
PublicRQNameBuilder
branch
from
a191ce5 to
a327f9b
Compare
Pilchie
added a commit
that referenced
this pull request
Apr 29, 2015
Expose a public API for building RQNames * Rename RQNameService to RQName and make public. * Rename TryBuildForPublicApi to From() and have it return null. * Remove TryBuild, since we only build RQNames for public Api's now. * Clean up implementation to not pass flag around for buildForPublicApi * Remove RQDynamicType * Create a singleton for System.Object. * Add a comment explaining why we erase dynamic. Fixes #55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.