Fix cast simplification within ConditionalAccessExpression.#1915
Merged
mavasani merged 1 commit intodotnet:masterfrom Apr 10, 2015
Merged
Fix cast simplification within ConditionalAccessExpression.#1915mavasani merged 1 commit intodotnet:masterfrom
mavasani merged 1 commit intodotnet:masterfrom
Conversation
Handle ConditionalAccessExpressionSyntax expressions within speculation analyzer to ensure that semantics of the conditional access expression and the WhenNotNull part don't change on cast simplication. Fixes dotnet#253
Contributor
Author
|
@srivatsn @shyamnamboodiripad @jmarolf @heejaechang @tmeschter can you please review? |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
mavasani
added a commit
that referenced
this pull request
Apr 10, 2015
Fix cast simplification within ConditionalAccessExpression. Handle ConditionalAccessExpressionSyntax expressions within speculation analyzer to ensure that semantics of the conditional access expression and the WhenNotNull part don't change on cast simplication. Fixes #253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle ConditionalAccessExpressionSyntax expressions within speculation analyzer to ensure that semantics of the conditional access expression and the WhenNotNull part don't change on cast simplication.
Fixes #253