show conditional element access sig-help after arbitrary expressions#1793
Merged
brettfo merged 1 commit intodotnet:masterfrom Apr 7, 2015
Merged
show conditional element access sig-help after arbitrary expressions#1793brettfo merged 1 commit intodotnet:masterfrom
brettfo merged 1 commit intodotnet:masterfrom
Conversation
Member
There was a problem hiding this comment.
There's TextSpan.FromBounds if that's nicer.
Member
|
👍 |
Member
Author
|
@basoundr Good catch, I've corrected the TextSpan creation to account for substantia (trivia is anything but trivial). @jasonmalinowski Thanks for that, TextSpan.FromBounds is exactly what I wanted. @Pilchie comment change was intentional and I've made it more explicit. |
the old model would only appear after an identifier name
brettfo
force-pushed
the
conditional-access-sig-help
branch
from
a4e4a54 to
4a475f6
Compare
brettfo
added a commit
that referenced
this pull request
Apr 7, 2015
show conditional element access sig-help after arbitrary expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old model would only appear after an identifier name. No change was required for VB but there weren't tests so I added them. Fixes #32.
Tagging for review: @Pilchie @dpoeschl @jasonmalinowski @rchande @balajikris @basoundr