Added failing test cases for void scripts with a dynamic receiver.#169
Added failing test cases for void scripts with a dynamic receiver.#169tmat merged 2 commits intodotnet:masterfrom
Conversation
Added failing test cases for void scripts with a dynamic receiver.
|
Just to check -- these tests fail because of a current bug in the code? We like to keep tests "green", so if they're expected to fail mark them with [Fact(Skip = "Bug ####")] where #### is the number of a GitHub issue. That way whoever is fixing the bug can find the tests and enable them when they fix it. |
|
@jasonmalinowski , yes they are failing due to a bug in the code. |
|
@ManishJayaswal This pull request is very old. If we're not planning to pull it, can you please close it? |
|
I think it will encourage potential contributors if dotnet team start reacting to pull requests rather quickly. 714 opened issues |
Added failing test cases for void scripts with a dynamic receiver.
6 participants
Scripts with a void return value throw exception when the receiver is dynamic.
Running the added test cases will fail with a "Cannot implicitly convert type 'void' to 'object'" exception.