Skip to content

Speedup Request::WriteToPipe#12

Closed
apolukhin wants to merge 1 commit intodotnet:masterfrom
apolukhin:patch-1
Closed

Speedup Request::WriteToPipe#12
apolukhin wants to merge 1 commit intodotnet:masterfrom
apolukhin:patch-1

Conversation

@apolukhin
Copy link

Reserve buffer to avoid reallocations and data copying (not tested)

Reserve buffer to avoid reallocations and data copying
@pharring
Copy link
Contributor

I haven't seen any bottlenecks in this code, but the change looks reasonable.
However, it should be noted that we intend to replace this C++ code with C# in the near future.
(I thought we had an issue tracking that, but I can't find it)

@theoy
Copy link
Contributor

theoy commented Feb 4, 2015

@pharring is right - we're in active planning to replace this component with a managed implementation (issue #137). Thanks a ton for the tip though. We're really appreciative that community members are reviewing the code and proposing improvements. ❤️

@theoy theoy modified the milestones: Unknown, 1.1 Feb 4, 2015
@gafter
Copy link
Member

gafter commented Feb 17, 2015

@Jenkins test this please

@gafter
Copy link
Member

gafter commented Mar 18, 2015

@agocke If this pull request is obsolete, can you please close it?

@gafter
Copy link
Member

gafter commented Apr 5, 2015

Closing this PR, as the relevant code no longer exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants