Update properties when a rule set is removed#1048
Conversation
Fixes dotnet#260. When a rule set file is removed or renamed we need to update the related CodeAnalysisRuleSet properties in the project file. Otherwise the build will break when the compiler complains that it cannot find the file.
|
@srivatsn @mavasani @shyamnamboodiripad @heejaechang @jmarolf @JohnHamby Could you take a look, please? |
|
👍 |
There was a problem hiding this comment.
Does this trigger diagnostic re-computation in the IDE diagnostic service to account for rule changes? I presume it should as it is a project change, but still would be good to confirm through a manual test, if you haven't already done so.
There was a problem hiding this comment.
It does, if changing the .ruleset file causes the compiler options to change. I would not necessarily expect them to be recomputed if the old file and the new file end up with the same options.
|
👍 |
There was a problem hiding this comment.
Consider adding <!-- Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. --> at the top of the file after the xml declation.
Update properties when a rule set is removed
5 participants
Fixes #260.
When a rule set file is removed or renamed we need to update the
related CodeAnalysisRuleSet properties in the project file. Otherwise
the build will break when the compiler complains that it cannot find the
file.