Skip to content

Deleting/renaming a ruleset in SolnExplorer should automatically update ProjectProperties #260

@srivatsn

Description

@srivatsn

Ported from TFS WorkItem: 1115014


Repro Steps:

1. Open a project with an analyzer and ruleset

2. Delete the ruleset file in SolnExplorer

 

What I expect: Build window shouldn't show any warnings about "missing ruleset file". And Analyzers>EditRuleSet should succeed.

 

WHAT I GET: a warning about missing ruleset file. And Analyzers>EditRuleSet fails with a message about missing ruleset.


Revisions:

  1. Created By Lucian Wischik (1/26/2015 3:20:38 PM)

I would love for "delete ruleset in SolutionExplorer" to be the intended supported way to rename/remove a ruleset, since that's how I use SolnExplorer the rest of the time. I don't want there to be additional hidden settings that I need to tweak.

 

The current approach (where you have to go to Project Properties > CodeAnalysis > ruleset) isn't very discoverable.


  1. Edited By Lucian Wischik (1/26/2015 3:22:22 PM)

Shyam had filed related bug 1082443 about a variety of ruleset issues. Tom writes:

 

I think we ended up fixing the issues we knew how to fix at the time, and took a wait-and-see approach to the others.

 

We need to do something better here. I think we can update the project system code to watch for deletes of .ruleset files and simply delete any CodeAnalysisRuleSet properties that refer to the same path. We might be able to handle renames that way, too.

 

I hate having to muck around in the project system code, but it’s very silly that we’ve gone to a lot of effort to add the .ruleset file to your project for you and then blow up the moment you delete it.


Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions