-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
Area-CompilersConcept-APIThis issue involves adding, removing, clarification, or modification of an API.This issue involves adding, removing, clarification, or modification of an API.Feature RequestResolution-By DesignThe behavior reported in the issue matches the current designThe behavior reported in the issue matches the current designVerified
Description
Both AnalyzeControlFlow and AnalyzeDataFlow are marked internal within SemanticModel.
They're exposed via extension methods in ModelExtensions.AnalyzeControlFlow and ModelExtension.AnalyzeDataFlow
I don't think accessing these methods through extension methods provides any value. I propose the extension methods be removed (for the above methods, and their other overload) and we simply mark the corresponding methods within SemanticModel as public.
If the team agrees, I can go ahead and submit a PR for this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area-CompilersConcept-APIThis issue involves adding, removing, clarification, or modification of an API.This issue involves adding, removing, clarification, or modification of an API.Feature RequestResolution-By DesignThe behavior reported in the issue matches the current designThe behavior reported in the issue matches the current designVerified