Skip to content

Make SemanticModel's Analyze*Flow methods public. Remove corresponding extension methods. #187

@JoshVarty

Description

@JoshVarty

Both AnalyzeControlFlow and AnalyzeDataFlow are marked internal within SemanticModel.

They're exposed via extension methods in ModelExtensions.AnalyzeControlFlow and ModelExtension.AnalyzeDataFlow

I don't think accessing these methods through extension methods provides any value. I propose the extension methods be removed (for the above methods, and their other overload) and we simply mark the corresponding methods within SemanticModel as public.

If the team agrees, I can go ahead and submit a PR for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CompilersConcept-APIThis issue involves adding, removing, clarification, or modification of an API.Feature RequestResolution-By DesignThe behavior reported in the issue matches the current designVerified

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions