Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/roslyn
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e7629a643c
Choose a base ref
...
head repository: dotnet/roslyn
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c167adef82
Choose a head ref
  • 4 commits
  • 20 files changed
  • 5 contributors

Commits on Aug 9, 2025

  1. Fix issue where analyzers are missing when computing diagnostics OOP

    If you were to have the same analyzer added as both a host analyzer
    and a project analyzer, we might end up removing it from the "project
    analyzer" set when we create the project CompilationWithAnalyzers. This
    confuses later code since it expects the analyzers to be present.
    
    This was regressed in c860af4,
    where a mechanical refactoring took us from having a single
    CompilationWithAnalyzers to two, one for project analyzers and one for
    host analyzers. The loop in the method was copied into two, but the
    set wasn't cleared between the two loops. I believe the intent was to
    clear out the set (rather than the set persist to deal with duplicates
    between the host and project sets), given the comment implies we do
    want duplicates to overwrite in the analyzerMap that we're also
    producing.
    
    I also split the two analyzer maps, one for project analyzers and one for
    host analyzers. If you don't do this, it means that a conflict where the
    same analyzer existing in both sets will overwrite each other, later
    code will then return a project analyzer which might be a different
    isntance than the host analyzer equivalent.
    jasonmalinowski authored and github-actions committed Aug 9, 2025
    Configuration menu
    Copy the full SHA
    876bb30 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2025

  1. Fixing build.

    AbhitejJohn committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    5f20df3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2025

  1. [17.14] Move Copilot context provider to EA.Copilot and handler to La…

    …nguageServer (#79760)
    
    * Move Copilot context provider to EA.Copilot and handler to LanguageServer (#77973)
    
    * remove semantic search from expected errors
    
    * Revert "remove semantic search from expected errors"
    
    This reverts commit 3f613ee.
    
    * use a producer/consumer pattern
    
    * Revert "use a producer/consumer pattern"
    
    This reverts commit 86802b4.
    
    * Cleanup the code we have to run copilot code in parallel
    
    * Simplify further
    
    * Move into helper
    
    * Simplify
    
    * Update src/Features/ExternalAccess/Copilot/Completion/ICSharpCopilotContextProviderService.cs
    
    * fix
    
    * Add copilot tests IVT to ExternalAccess.Copilot (#78455)
    
    ---------
    
    Co-authored-by: Gen Lu <[email protected]>
    Co-authored-by: Cyrus Najmabadi <[email protected]>
    3 people authored Aug 12, 2025
    Configuration menu
    Copy the full SHA
    a466013 View commit details
    Browse the repository at this point in the history
  2. [release/dev17.14] Fix issue where analyzers are missing when computi…

    …ng diagnostics OOP (#79861)
    
    Backport of #79821 to release/dev17.14
    
    /cc @jasonmalinowski
    
    ## Customer Impact
    
    ## Regression
    
    - [ ] Yes
    - [ ] No
    
    [If yes, specify when the regression was introduced. Provide the PR or
    commit if known.]
    
    ## Testing
    
    [How was the fix verified? How was the issue missed previously? What
    tests were added?]
    
    ## Risk
    
    [High/Medium/Low. Justify the indication by mentioning how risks were
    measured and addressed.]
    AbhitejJohn authored Aug 12, 2025
    Configuration menu
    Copy the full SHA
    c167ade View commit details
    Browse the repository at this point in the history
Loading