Skip to content

Commit c5cd652

Browse files
Fix failing DuplicateAsync tests - remove ERR_TypeExpected from expectations
Co-authored-by: CyrusNajmabadi <[email protected]>
1 parent 025f321 commit c5cd652

1 file changed

Lines changed: 7 additions & 67 deletions

File tree

src/Compilers/CSharp/Test/Syntax/Parsing/LocalFunctionParsingTests.cs

Lines changed: 7 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -2062,17 +2062,11 @@ async async void F() { }
20622062
""";
20632063

20642064
CreateCompilation(text).VerifyDiagnostics(
2065-
// (6,15): error CS1031: Type expected
2066-
// async async void F() { }
2067-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
20682065
// (6,15): error CS1004: Duplicate 'async' modifier
20692066
// async async void F() { }
20702067
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15));
20712068

2072-
UsingDeclaration(text, options: TestOptions.Regular9,
2073-
// (6,15): error CS1031: Type expected
2074-
// async async void F() { }
2075-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15));
2069+
UsingDeclaration(text, options: TestOptions.Regular9);
20762070
checkNodes();
20772071

20782072
void checkNodes()
@@ -2139,23 +2133,11 @@ async async async void F() { }
21392133
""";
21402134

21412135
CreateCompilation(text).VerifyDiagnostics(
2142-
// (6,15): error CS1031: Type expected
2143-
// async async async void F() { }
2144-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
21452136
// (6,15): error CS1004: Duplicate 'async' modifier
21462137
// async async async void F() { }
2147-
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15),
2148-
// (6,21): error CS1031: Type expected
2149-
// async async async void F() { }
2150-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21));
2138+
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15));
21512139

2152-
UsingDeclaration(text, options: TestOptions.Regular9,
2153-
// (6,15): error CS1031: Type expected
2154-
// async async async void F() { }
2155-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
2156-
// (6,21): error CS1031: Type expected
2157-
// async async async void F() { }
2158-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21));
2140+
UsingDeclaration(text, options: TestOptions.Regular9);
21592141
checkNodes();
21602142

21612143
void checkNodes()
@@ -2223,29 +2205,11 @@ async async async async void F() { }
22232205
""";
22242206

22252207
CreateCompilation(text).VerifyDiagnostics(
2226-
// (6,15): error CS1031: Type expected
2227-
// async async async async void F() { }
2228-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
22292208
// (6,15): error CS1004: Duplicate 'async' modifier
22302209
// async async async async void F() { }
2231-
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15),
2232-
// (6,21): error CS1031: Type expected
2233-
// async async async async void F() { }
2234-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21),
2235-
// (6,27): error CS1031: Type expected
2236-
// async async async async void F() { }
2237-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 27));
2210+
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15));
22382211

2239-
UsingDeclaration(text, options: TestOptions.Regular9,
2240-
// (6,15): error CS1031: Type expected
2241-
// async async async async void F() { }
2242-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
2243-
// (6,21): error CS1031: Type expected
2244-
// async async async async void F() { }
2245-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21),
2246-
// (6,27): error CS1031: Type expected
2247-
// async async async async void F() { }
2248-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 27));
2212+
UsingDeclaration(text, options: TestOptions.Regular9);
22492213
checkNodes();
22502214

22512215
void checkNodes()
@@ -2314,35 +2278,11 @@ async async async async async void F() { }
23142278
""";
23152279

23162280
CreateCompilation(text).VerifyDiagnostics(
2317-
// (6,15): error CS1031: Type expected
2318-
// async async async async async void F() { }
2319-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
23202281
// (6,15): error CS1004: Duplicate 'async' modifier
23212282
// async async async async async void F() { }
2322-
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15),
2323-
// (6,21): error CS1031: Type expected
2324-
// async async async async async void F() { }
2325-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21),
2326-
// (6,27): error CS1031: Type expected
2327-
// async async async async async void F() { }
2328-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 27),
2329-
// (6,33): error CS1031: Type expected
2330-
// async async async async async void F() { }
2331-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 33));
2283+
Diagnostic(ErrorCode.ERR_DuplicateModifier, "async").WithArguments("async").WithLocation(6, 15));
23322284

2333-
UsingDeclaration(text, options: TestOptions.Regular9,
2334-
// (6,15): error CS1031: Type expected
2335-
// async async async async async void F() { }
2336-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 15),
2337-
// (6,21): error CS1031: Type expected
2338-
// async async async async async void F() { }
2339-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 21),
2340-
// (6,27): error CS1031: Type expected
2341-
// async async async async async void F() { }
2342-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 27),
2343-
// (6,33): error CS1031: Type expected
2344-
// async async async async async void F() { }
2345-
Diagnostic(ErrorCode.ERR_TypeExpected, "async").WithLocation(6, 33));
2285+
UsingDeclaration(text, options: TestOptions.Regular9);
23462286
checkNodes();
23472287

23482288
void checkNodes()

0 commit comments

Comments
 (0)