Rename bugfix - When component is in the same file#8954
Merged
maryamariyan merged 8 commits intomainfrom Jul 18, 2023
Merged
Conversation
Text edit on the file being renamed gets lost. To fix this we first apply text edits and then apply file rename as the last thing to do. Contributes to: #8541
we'd want the uri refer to new renamed uri
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Functionality wise, this is great. One suggestion to reconsider the placement of the uri remapping though.
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Refactoring/RenameEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Refactoring/RenameEndpointTest.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Refactoring/RenameEndpoint.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Jul 17, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Refactoring/RenameEndpoint.cs
Outdated
Show resolved
Hide resolved
maryamariyan
force-pushed
the
bugfix-rename
branch
from
aef8b36 to
e1d1dbc
Compare
ryzngard
reviewed
Jul 17, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Refactoring/RenameEndpoint.cs
Outdated
Show resolved
Hide resolved
ryzngard
approved these changes
Jul 17, 2023
1 task
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text edit on the file being renamed gets lost.
To fix this we first apply text edits and then
apply file rename as the last thing to do.
To do:
Contributes to: #8541