add review comment to sb files#8787
Conversation
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Fine by me, but might I also suggest adding the appropriate lines to the CODEOWNERS file, so we don't have to rely on humans reading comments. Humans tend to be unreliable 😁
|
Yes, please use the CODEOWNERS file for this purpose. |
Initially wanted to add both the comment and the If you are OK with granting write permissions to |
|
I'll ask in our teams channel for thoughts. |
|
@333fred soft ping - are there any updates regarding the write access? Thank you! |
|
Should be added now |
|
@oleksandr-didyk you should have write access now. |
Thank you! I added the |
oleksandr-didyk
force-pushed
the
add-sb-review-comment
branch
from
537c2cd to
33fd2d9
Compare
4 participants
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter
SourceBuild*files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))