Update dependencies and workaround dotnet/sdk#2976 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
natemcmaster
commented
Feb 22, 2019
•
natemcmaster
commented
- Update to latest extensions, corefx, and core-setup build
- Workaround All packages targeting netcoreapp3.0 have a 'Microsoft.NETCore.Platforms' dependency in nuspec sdk#2976
- Update xunit to 2.4.1. (required to consume latest Microsoft.AspNetCore.Testing)
- Add workaround to resolve conflicts between SDK and dependency versions
- Remove NETStandard package version override
|
Ready to merge, just waiting for review approval. |
dougbu
approved these changes
Feb 22, 2019
| @@ -128,8 +128,7 @@ | |||
| <VSIX_MicrosoftVisualStudioLanguageServicesPackageVersion>3.0.0-beta2-18612-05</VSIX_MicrosoftVisualStudioLanguageServicesPackageVersion> | |||
| <VSIX_MicrosoftVisualStudioLanguageServicesRazorRemoteClientPackageVersion>3.0.0-beta2-18612-05</VSIX_MicrosoftVisualStudioLanguageServicesRazorRemoteClientPackageVersion> | |||
| <XunitAnalyzersPackageVersion>0.10.0</XunitAnalyzersPackageVersion> | |||
| <XunitPackageVersion>2.3.1</XunitPackageVersion> | |||
| <XunitRunnerVisualStudioPackageVersion>2.4.0</XunitRunnerVisualStudioPackageVersion> | |||
| <XunitVersion>2.4.1</XunitVersion> | |||
There was a problem hiding this comment.
Odd. aspnet/Extensions is on 2.4.0 and that bumping things up here would cause different package downgrade errors. Glad it doesn't.
There was a problem hiding this comment.
Should we move aspnet/Extensions to Xunit
2.4.1and (then) the other repos?
Yes, but I would do it in reverse order. Move AspNetCore to 2.4.1, then Extensions
There was a problem hiding this comment.
Move AspNetCore to 2.4.1, then Extensions
In release/3.0-preview3 or master?
There was a problem hiding this comment.
master. It's not urgent for preview3
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
May 17, 2020
…dotnet/razor#238) * Update dependencies * Add workaround for dotnet/sdkdotnet/aspnetcore-tooling#2976 * Remove unused NETStandard package version variable and overrides * Update xunit to 2.4.1 \n\nCommit migrated from dotnet/razor@6708297
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
…dotnet/razor#238) * Update dependencies * Add workaround for dotnet/sdkdotnet/aspnetcore-tooling#2976 * Remove unused NETStandard package version variable and overrides * Update xunit to 2.4.1 \n\nCommit migrated from dotnet/razor@6708297 Commit migrated from dotnet/aspnetcore@61e85256a653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.