Take 2 to fix the image load regression#12683
Merged
davidwengier merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
ToddGrun
reviewed
Jan 15, 2026
| /// <param name="requestInvoker"></param> | ||
| [Export(typeof(LSPRequestInvokerWrapper))] | ||
| [method: ImportingConstructor] | ||
| internal sealed class LSPRequestInvokerWrapper(Lazy<LSPRequestInvoker> requestInvoker) |
Contributor
Member
Author
There was a problem hiding this comment.
I don't know. I'll merge this, and do a test insertion for that change and see what happens, then we can more easily compare in PIT etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2677553
PIT run shows this prevents the image load. It's not flagged as a highlight though :(
https://dev.azure.com/devdiv/DevDiv/_apps/hub/ms-vseng.pit-vsengPerf.pit-hub?targetBuild=11413.276.dn-bot.260115.000316.700145&targetBranch=main&targetPerfBuildId=13099347&runGroup=PerfDDRITs64&baselineBuild=11413.276&baselineBranch=main
Can't deep link apparently, but looking at WebTools Debugging test, Stop Debugging scenario, adjusted images in memory counter.