[Test only change] Only track steps when needed#12479
Merged
chsienki merged 1 commit intodotnet:mainfrom Nov 12, 2025
Merged
Conversation
davidwengier
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #12477 I noticed that
RazorSourceGeneratorTagHelperTests.ViewImportstests were taking over 30 seconds per run (and thanks to the theory we run it 11 times) seriously slowing down the tests.After some investigation I discovered it's actually the generator tracking infrastructure that was causing the slowness. Disabling tracking makes them take around 500ms. I'll open an issue on roslyn to address that, but we only actually use tracking for a single test, so I've just disabled it for all the other tests in the assembly.
I also included a fix to the baseline generation that occurs due to #12477