Various follow ups from Roslyn features#12435
Merged
davidwengier merged 6 commits intodotnet:mainfrom Nov 3, 2025
Merged
Conversation
Member
Author
|
That source generator test failure is very surprising. |
Member
|
I wonder if that's a change in Roslyn? Might be worth trying just the version bump with none of the tooling changes and see if it still happens. I don't know how tooling changes could affect the source generator. |
Member
Author
|
Yeah, I don't see how this could be anything but a Roslyn change, but I completely forgot to dig in and find out. Thanks for the reminder :) |
Member
Author
|
That warning was removed entirely from the compiler: dotnet/roslyn#77001 |
DustinCampbell
approved these changes
Nov 3, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
The code changes look good to me!
Roslyn no longer reports CS1998 dotnet/roslyn#77001
chsienki
approved these changes
Nov 3, 2025
This was referenced Nov 4, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things I've been tracking from Roslyn: