Support Go To Def for Mvc tag helpers in cohosting#12102
Merged
davidwengier merged 9 commits intodotnet:mainfrom Aug 14, 2025
Merged
Support Go To Def for Mvc tag helpers in cohosting#12102davidwengier merged 9 commits intodotnet:mainfrom
davidwengier merged 9 commits intodotnet:mainfrom
Conversation
chsienki
approved these changes
Aug 13, 2025
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/GoToDefinition/RemoteGoToDefinitionService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/RemoteTagHelperSearchEngine.cs
Show resolved
Hide resolved
.../src/Microsoft.AspNetCore.Razor.LanguageServer/Definition/RazorComponentDefinitionService.cs
Outdated
Show resolved
Hide resolved
...icrosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostGoToDefinitionEndpointTest.cs
Show resolved
Hide resolved
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6440
Actually taking advantage of cohosting!
In the LSP editor, it was impossible for Go To Def to work on Mvc tag helpers because their definitions come from C# code, and all we have is a type name with no access to a compilation. In cohosting we have the compilation easily availalle, so we can finally fix this issue (without extra metadata on tag helpers).