Conversation
davkean
approved these changes
Jun 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
=======================================
Coverage 67.93% 67.93%
=======================================
Files 728 728
Lines 36608 36608
Branches 2128 2128
=======================================
Hits 24869 24869
Misses 11331 11331
Partials 408 408
Continue to review full report at Codecov.
|
Pilchie
approved these changes
Jun 21, 2018
Member
|
@brettfo What's going on with this PR? |
Member
Author
|
I've made some changes to dotnet/roslyn-tools#280 that should make this unnecessary; any repo that consumes the latest build tools will automatically get the version numbers embedded in the manifests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following criteria must be met before this can be merged:
versionproperty to the inserted component roslyn-tools#280 must be completed.versionproperty to the inserted component roslyn-tools#280.info/buildVersionproperty (mentioned below):[internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.Editors.vsman[internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.NetCore.ProjectTemplates.vsman[internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.NetCore.ProjectTemplates.1.x.vsman[internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.ProjectSystem.Managed.vsmanWhat this does:
To help make our internal automation easier, we need to publish a version number with the insertion component. The net result of this is the
artifacts\Release\VSSetup\Insertion\*.vsmanfiles will be modified to this: