Skip to content

version the .vsman insertion files#3669

Closed
brettfo wants to merge 1 commit intomasterfrom
vsman-version
Closed

version the .vsman insertion files#3669
brettfo wants to merge 1 commit intomasterfrom
vsman-version

Conversation

@brettfo
Copy link
Copy Markdown
Member

@brettfo brettfo commented Jun 21, 2018

The following criteria must be met before this can be merged:

  1. add a version property to the inserted component roslyn-tools#280 must be completed.
  2. This repo must be updated to the latest version of the RepoToolset containing the changes in add a version property to the inserted component roslyn-tools#280.
  3. Run a full-signed build with these changes and verify that the following files specify a info/buildVersion property (mentioned below):
    • [internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.Editors.vsman
    • [internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.NetCore.ProjectTemplates.vsman
    • [internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.NetCore.ProjectTemplates.1.x.vsman
    • [internal-drop-location]\VSSetup\Insertion\Microsoft.VisualStudio.ProjectSystem.Managed.vsman

What this does:

To help make our internal automation easier, we need to publish a version number with the insertion component. The net result of this is the artifacts\Release\VSSetup\Insertion\*.vsman files will be modified to this:

{
  // ...
  "info": {
    // ...
    "buildVersion": "2.8.0.6302101", // <-- added this line
    // ...
  }
  // ...
}

@brettfo brettfo requested review from jmarolf and tannergooding June 21, 2018 21:08
@brettfo brettfo requested a review from a team as a code owner June 21, 2018 21:08
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3669 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3669   +/-   ##
=======================================
  Coverage   67.93%   67.93%           
=======================================
  Files         728      728           
  Lines       36608    36608           
  Branches     2128     2128           
=======================================
  Hits        24869    24869           
  Misses      11331    11331           
  Partials      408      408
Flag Coverage Δ
#debug 67.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b590fd...f5bd38c. Read the comment docs.

@davkean
Copy link
Copy Markdown
Member

davkean commented Jul 11, 2018

@brettfo What's going on with this PR?

@brettfo
Copy link
Copy Markdown
Member Author

brettfo commented Jul 12, 2018

I've made some changes to dotnet/roslyn-tools#280 that should make this unnecessary; any repo that consumes the latest build tools will automatically get the version numbers embedded in the manifests.

@brettfo brettfo closed this Jul 12, 2018
@brettfo brettfo deleted the vsman-version branch July 12, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants