Skip to content

Add reference assemblies#627

Closed
billwert wants to merge 4 commits intodotnet:masterfrom
billwert:add-reference-assemblies
Closed

Add reference assemblies#627
billwert wants to merge 4 commits intodotnet:masterfrom
billwert:add-reference-assemblies

Conversation

@billwert
Copy link
Contributor

No description provided.

@billwert
Copy link
Contributor Author

fails due to dotnet/BenchmarkDotNet#1197. I have another idea to unblock it though..

@adamsitnik
Copy link
Member

I saw dotnet/BenchmarkDotNet#1197 and I need to wrap my head around it. Tomorrow I am OOF so I won't have a solution this week.

@billwert billwert force-pushed the add-reference-assemblies branch from 8b6e2be to 5f50118 Compare July 11, 2019 21:11
Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michellemcdaniel michellemcdaniel self-requested a review July 11, 2019 22:15
@billwert
Copy link
Contributor Author

This is going to have to wait until we get a fix from BDN. The Directory.Build.props approach is blocked specifically.

@billwert billwert closed this Jul 14, 2019
@billwert billwert deleted the add-reference-assemblies branch October 29, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants