Repository navigation
Run CoreCLR microbenchmarks on macOS 26 Arm64 M4 - #5323
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: d3ea3c9b-20b5-43c5-8e73-5a61a2120de9
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Pipeline expansion and end-to-end macOS validation remain outstanding.
Review effort: Lite
Findings: None
What changed in this PR
Enables CoreCLR microbenchmarks on the macOS 26 Arm64 M4 performance queue.
Changes:
- Adds the enabled-by-default
m4Microconfiguration. - Targets the explicit M4 queue and machine pool.
- Excludes release branches.
| File | Description |
|---|---|
eng/pipelines/runtime-perf-jobs.yml |
Defines and schedules the macOS Arm64 M4 microbenchmark job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Disable other benchmark configurations and iOS builds/runs for M4 queue validation. Revert this commit after the trial. Co-authored-by: Copilot <[email protected]> Copilot-Session: d3ea3c9b-20b5-43c5-8e73-5a61a2120de9
Resolve symlinked project and working-directory paths before invoking dotnet to avoid transitive reference loss. Cover direct and linked paths for both build modes. Co-authored-by: Copilot <[email protected]> Copilot-Session: d3ea3c9b-20b5-43c5-8e73-5a61a2120de9
Reverts temporary Mac-only configuration from fdec43b, retaining the M4 benchmark job and canonical project-path fix. Co-authored-by: Copilot <[email protected]> Copilot-Session: d3ea3c9b-20b5-43c5-8e73-5a61a2120de9
LoopedBard3
previously approved these changes
Sep 29, 2026
Keep the macOS build enabled while guarding M4 runs on both release branch prefixes, which may lack the required runtime build support. Co-authored-by: Copilot <[email protected]> Copilot-Session: d3ea3c9b-20b5-43c5-8e73-5a61a2120de9
LoopedBard3
approved these changes
Sep 29, 2026
DrewScoggins
added a commit
that referenced
this pull request
Sep 29, 2026
DrewScoggins
added a commit
to dotnet/runtime
that referenced
this pull request
Sep 30, 2026
## Summary Add macOS Arm64 CoreCLR build artifacts for performance runs on `osx.26.arm64.m4.perf`. - Add an opt-in `osx_arm64` platform to the existing CoreCLR performance build template. - Enable it in the regular performance build jobs, including release branches containing this template, using the existing cross-build and artifact-upload paths. - Keep existing platform selections unchanged. The companion performance template retains its release-branch run guard to protect runtime branches without Mac build support. Companion PR: dotnet/performance#5323 adds the M4 microbenchmark job. This runtime change must land and be available to the internal performance pipeline before that job is enabled. ## Validation Six local YAML/structural checks passed across both repositories, covering duplicate keys, platform and queue selection, release guards, cross-build forwarding, artifact naming, and preservation of existing jobs. `git diff --check` passed. No macOS build, Azure Pipelines template expansion, or end-to-end Helix run was performed locally; those still require pipeline validation. > [!NOTE] > This PR was prepared with GitHub Copilot; this description is AI-generated. --------- Copilot-Session: d3ea3c9-20b5-43c5-8e73-5a61a2120de9
DrewScoggins
added a commit
that referenced
this pull request
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable CoreCLR microbenchmarks on the macOS 26 Arm64 M4 performance queue,
osx.26.arm64.m4.perf.m4Microconfiguration forosx_arm64.M4, avoiding the logical-machine mapper's Linux fallback.Dependency and rollout
Merge dotnet/runtime#134616 first, and ensure that build support is available in the runtime checkout used by the internal pipeline before enabling this job. The runtime PR produces the artifacts consumed here.
The Mac file-backed certificate support from #5257 is already merged; no certificate changes are needed in this PR.
Validation
Six local YAML/structural checks passed across both repositories, covering duplicate keys, platform and queue selection, release guards, cross-build forwarding, artifact naming, and preservation of existing jobs.
git diff --checkpassed.No macOS build, Azure Pipelines template expansion, or end-to-end Helix run was performed locally; those still require pipeline validation.
Note
This PR was prepared with GitHub Copilot; this description is AI-generated.