Remove dataclasses from ci_setup.py #3251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
radical
added a commit
to dotnet/runtime
that referenced
this pull request
Aug 11, 2023
#90424) This reverts commit bbe40f8. This caused perf pipeline runs to break. But dotnet/performance#3251 from @caaavik-msft, along with this revert will fix the issue. Issue: #90420
Member
|
Runs all have gotten through ci_setup step. And output looks good. |
DrewScoggins
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataclasses dependency in ci_setup.py is breaking the perf runs in the runtime repository, just going to remove the dependency altogether for now while we fix it in the future