Skip to content

[Net8.0] Update channel_map with net8 and organized 6v7v8 groupings. #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LoopedBard3 merged 6 commits into from
Nov 3, 2022
Merged

[Net8.0] Update channel_map with net8 and organized 6v7v8 groupings. #2585

LoopedBard3 merged 6 commits into from
Nov 3, 2022

Conversation

@LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Aug 30, 2022

Updated the channel_map with net8 channels and cleaned up the groups between net6, net7, and net8. Updating to net8 included setting main channel to point to net8. This is part of work to bring up net8.0 testing.

@LoopedBard3 LoopedBard3 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 30, 2022
@LoopedBard3 LoopedBard3 self-assigned this Aug 30, 2022
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Sep 15, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Sep 28, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 28, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Oct 18, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 18, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Oct 18, 2022

It looks like that for the micro runs, the current failure is related to CborWriter not being found:

[2022/10/18 20:30:21][INFO] $ dotnet build C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework net8.0 --no-restore /p:NuGetPackageRoot=C:\h\w\BA9109CC\p\artifacts\packages /p:UseSharedCompilation=false /p:BuildInParallel=false /m:1
[2022/10/18 20:30:21][INFO] MSBuild version 17.5.0-preview-22511-01+a440ea9cf for .NET
[2022/10/18 20:30:26][INFO]   Reporting -> C:\h\w\BA9109CC\p\artifacts\bin\Reporting\Release\netstandard2.0\Reporting.dll
[2022/10/18 20:30:28][INFO]   BenchmarkDotNet.Extensions -> C:\h\w\BA9109CC\p\artifacts\bin\BenchmarkDotNet.Extensions\Release\netstandard2.0\BenchmarkDotNet.Extensions.dll
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\CoseKeyHelpers.cs(62,66): error CS0246: The type or namespace name 'CborWriter' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\CoseKeyHelpers.cs(157,95): error CS0246: The type or namespace name 'CborReader' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(37,65): error CS0246: The type or namespace name 'CborConformanceMode' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(46,20): error CS0246: The type or namespace name 'CborConformanceMode' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(37,103): error CS0103: The name 'CborConformanceMode' does not exist in the current context [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborWriter.cs(14,17): error CS0246: The type or namespace name 'CborWriter' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] 
[2022/10/18 20:30:34][INFO] Build FAILED.
[2022/10/18 20:30:34][INFO] 
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\CoseKeyHelpers.cs(62,66): error CS0246: The type or namespace name 'CborWriter' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\CoseKeyHelpers.cs(157,95): error CS0246: The type or namespace name 'CborReader' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(37,65): error CS0246: The type or namespace name 'CborConformanceMode' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(46,20): error CS0246: The type or namespace name 'CborConformanceMode' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborReader.cs(37,103): error CS0103: The name 'CborConformanceMode' does not exist in the current context [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO] C:\h\w\BA9109CC\p\src\benchmarks\micro\libraries\System.Formats.Cbor\Perf.CborWriter.cs(14,17): error CS0246: The type or namespace name 'CborWriter' could not be found (are you missing a using directive or an assembly reference?) [C:\h\w\BA9109CC\p\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net8.0]
[2022/10/18 20:30:34][INFO]     0 Warning(s)
[2022/10/18 20:30:34][INFO]     6 Error(s)
[2022/10/18 20:30:34][INFO]

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Oct 21, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 21, 2022

Pull request contains merge conflicts.

@LoopedBard3
Updated channel_map with net8 and organized 6v7v8.
0e7fce1 
Add dotnet 8 to the nuget.config.

Disable maui projects on Net8.0.

Add Cbor to run on net 5.0+ and added net8.0 to TFMs.

Fix comment containing --.

Fix error in Microbenchmarks.csproj.

add channel to force main channel install in scenarios.yml.

Hopefully last fix for Microbenchmarks.

Don't install dotnet with init.sh, and updated version in global.json for testing. This will have to be setup to be automated on switch to new version.

Disable MauiScenarios pre-build.

Try updating nativeaot7.0 to 8.0.

Keep net7.0 branch as 7.0.1xx.

Undo changes not necessary for net8.0 for rebase.

Fix accidental change in scenarios.proj.
@LoopedBard3 LoopedBard3 force-pushed the SetMainChannelMapToNet8 branch from 4f919a4 to 0e7fce1 Compare November 3, 2022 18:18
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Nov 3, 2022

Run before reverting nativeaot back to use version 7.0 mostly succeeded in expected places, mostly having maui build issues and some individual failures in sdk_scenarios, merging. Fixes #2687.

@LoopedBard3 LoopedBard3 merged commit 860803b into dotnet:main Nov 3, 2022
@LoopedBard3 LoopedBard3 deleted the SetMainChannelMapToNet8 branch November 3, 2022 23:14
@LoopedBard3 LoopedBard3 mentioned this pull request Nov 3, 2022
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 4, 2022
Open
2 tasks
@radical radical mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caaavik-msft caaavik-msft caaavik-msft approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@cincuranet cincuranet Awaiting requested review from cincuranet

Assignees

@LoopedBard3 LoopedBard3

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoopedBard3 @caaavik-msft