Add Version perf tests #1694
Merged
Add Version perf tests #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Feb 21, 2021
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
Is the codegen different when the out parameter of format is a discard?
Member
|
@billwert could you please look at the build failure? It is not related to the change. |
Member
Author
Only if it could be inlined (it can't, and I don't see it ever being inlineable by default). |
adamsitnik
reviewed
Feb 22, 2021
Member
Author
|
Thanks, @adamsitnik. I added the tests you requested. |
adamsitnik
approved these changes
Mar 16, 2021
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Perfect! thank you @stephentoub 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.