Added basic FSharp benchmarks #1546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@billwert I need to fix a merge conflict, but is there anything else that I need to do here? |
billwert
suggested changes
Mar 3, 2021
Contributor
billwert
left a comment
billwert
left a comment
There was a problem hiding this comment.
Couple things:
- The pr.yml change may not be necessary. I pinged @DrewScoggins to see what he thinks.
- Can you explain what you're trying to accomplish with the 3.1 reference check? That will be problematic in our lab for two reasons. One, as you can see from the failures in CI it's going to fail in the release/5.0.1xx branch due to missing nuget paths (which is something that's not really fixable.) Second, we don't install a 3.1 .NET Core unless we're trying to run 3.1, so even if it had restored it would fail to execute. Depending on what you're trying to do we maybe can fix some of this, but it's better if we can just.. not. :)
| frameworks: # for Roslyn jobs we want to check .NET Core 3.0 only | ||
| - netcoreapp3.0 | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
I don't think this file is actually used - @DrewScoggins can you confirm?
Contributor
Author
|
@billwert I need to get a list of .NET Core DLL references in order to compile the benchmark test. I'm also fine just with testing .NET 5 and not .NET Core 3.1. |
Contributor
Author
|
Closing this as the scenarios trying to be addressed here require testing F# compiler APIs directly. Instead, we will just add F# scenarios in the "scenarios" folder of this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FSharp benchmarks to the repo. Contains a simple 'hello world' compilation benchmark.