Skip to content

Conversation

@MovGP0
Copy link

@MovGP0 MovGP0 commented Feb 20, 2015

only half finished, but would welcome feedback

@dnfclas
Copy link

dnfclas commented Feb 20, 2015

Hi @MovGP0, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@sergeybykov
Copy link
Contributor

@MovGP0 Great but I have a couple of issues with this,

It appears incompatible with VS 2013. If that's the case, it'll for sure break too many people that are not on the VS 2015 cutting edge.

It adds a dependency on Polly. Do you think it's worth it? Unable to compile the code, I can't easily see how it's used.

@MovGP0
Copy link
Author

MovGP0 commented Feb 20, 2015

I agree. Have used C# 6 and will better downgrade to C# 5, so that people do not need Roslyn.

Have used Polly is for retry and exception handling policies. Was a recommendation of Scott Hanselman and I tend to like it. Its harder to comply with .NET guidelines without it.

@MovGP0 MovGP0 closed this Feb 20, 2015
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants