[BuildCheck] Editor config support#9811
Conversation
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
First quick pass. Looks good! :-)
Though I'd love to see my static leftover being turned into mockable interface
I haven't reviewed the copied files though... (hopefully we'll anyways end up consuming a shared version from Roslyn)
…dd Roslyn editorconfig tests for section matcher
…t implementetion.
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
I added couple additional comments
Can you add to this doc some details about what the exposed interface to this stuff is? That is, what interfaces/whatever MSBuild code will be using to learn about editorconfig-driven configuration? Also, does this PR introduce the patterns that we'll use to map (stuff in the .editorconfig) to (severity for rules), or is that coming later? |
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Re-reviewed latest state - looks goot to go for initial version!
Added example of the usage (API) and what it returns.
The PR introduced both -> .editorconfig parsing and mapping the configuration to the actual rules |
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
I haver couple comments for consideration - but overall looks good!
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Thnak you for all the improvement roundtrips on the PR!
5 participants
First iteration of the code with latest merged changes from exp/build-analyzers.
Design capturing current implementation could be viewed here: https://github.com/dotnet/msbuild/tree/dev/f-alizada/support-editorconfig/src/Build/BuildCheck/Infrastructure/EditorConfig
Discussions:
Current implementation.
The editorConfig parsing functionality is being used by https://github.com/dotnet/msbuild/blob/dev/f-alizada/support-editorconfig/src/Build/BuildCheck/Infrastructure/ConfigurationProvider.cs
to fetch all configs from .editorconfig.