Condition APICompat workaround on desktop msbuild only#9797
Merged
rainersigwald merged 1 commit intomainfrom Feb 28, 2024
Merged
Condition APICompat workaround on desktop msbuild only#9797rainersigwald merged 1 commit intomainfrom
rainersigwald merged 1 commit intomainfrom
Conversation
Member
|
I wonder if this is related the |
mmitche
approved these changes
Feb 28, 2024
Member
Author
|
@dotnet/kitten can you please approve and merge? |
rainersigwald
approved these changes
Feb 28, 2024
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
The MicroBuild official build images should get 17.9 before long, which should be the time when we can remove this. Not sure the ETA though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt of cf75831
We need to keep this workaround in msbuild until the .NET Framework legs build with a VS that either uses a 8.0.2xx or a 9.0 SDK. To unblock building msbuild for unified-build in the VMR, condition this target on desktop msbuild only.