Merged
Conversation
MSBuild is now using the 201 SDK. This also breaks usage of the dotnet msbuild engine in VMR builds.
Member
Author
|
This should unblock dotnet/installer#18770 |
ViktorHofer
approved these changes
Feb 28, 2024
Member
|
Unfortunately this still leads to the same issue - so reverting now. |
JanKrivanek
added a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit cf75831.
JanKrivanek
added a commit
that referenced
this pull request
Feb 28, 2024
Member
Author
@JanKrivanek my hunch is that:
I'm not sure what the right solution is here. You can't rely on core msbuild for the build in all cases, due to generating TLBs in certain cases (and needing to finding the tlb tooling), but it's hard to predict which msbuild is going to get used in various CI/PR/Officail scenarios. |
Member
|
Submitted #9797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9720
MSBuild is now using the 201 SDK. This also breaks usage of the dotnet msbuild engine in VMR builds.