Skip to content

Remove api compat workaround#9791

Merged
JanKrivanek merged 1 commit intomainfrom
mmitche-patch-1
Feb 28, 2024
Merged

Remove api compat workaround#9791
JanKrivanek merged 1 commit intomainfrom
mmitche-patch-1

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Feb 27, 2024

Fixes #9720

MSBuild is now using the 201 SDK. This also breaks usage of the dotnet msbuild engine in VMR builds.

MSBuild is now using the 201 SDK. This also breaks usage of the dotnet msbuild engine in VMR builds.
@mmitche mmitche requested a review from a team as a code owner February 27, 2024 23:16
@mmitche
Copy link
Member Author

mmitche commented Feb 27, 2024

This should unblock dotnet/installer#18770

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JanKrivanek JanKrivanek merged commit cf75831 into main Feb 28, 2024
@JanKrivanek JanKrivanek deleted the mmitche-patch-1 branch February 28, 2024 07:09
@JanKrivanek
Copy link
Member

Unfortunately this still leads to the same issue - so reverting now.
Not sure now, why PR build didn't catch this, but it failed upon merging:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9155329&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=94418e61-6648-5751-f7d4-a14f4e5e2bb7&l=157

JanKrivanek added a commit that referenced this pull request Feb 28, 2024
JanKrivanek added a commit that referenced this pull request Feb 28, 2024
@mmitche
Copy link
Member Author

mmitche commented Feb 28, 2024

Unfortunately this still leads to the same issue - so reverting now. Not sure now, why PR build didn't catch this, but it failed upon merging:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9155329&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=94418e61-6648-5751-f7d4-a14f4e5e2bb7&l=157

@JanKrivanek my hunch is that:

  • In CI/PRs, the version of VS on the machine is newer, and has the updated version of desktop msbuild.
  • In your official build, the version is older, and only has 17.8 or whatever. This causes either that VS to be used, or the 17.8.3 xcopy-msbuild.

I'm not sure what the right solution is here. You can't rely on core msbuild for the build in all cases, due to generating TLBs in certain cases (and needing to finding the tlb tooling), but it's hard to predict which msbuild is going to get used in various CI/PR/Officail scenarios.

@ViktorHofer
Copy link
Member

Submitted #9797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kitten] Remove APICompat workaround once 8.0.2 or 9.xxx is consumed

3 participants