[BinFmt] Error on serialization custom events in by default in .NET framework#9318
Merged
JanKrivanek merged 6 commits intodotnet:mainfrom Nov 21, 2023
Merged
Conversation
JanKrivanek
approved these changes
Oct 10, 2023
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good to me.
The changewave should be 17.9 unless you are explicitly convinced it should stay under 17.8
Member
|
Can you remind me what partner team buyoff we have on this? Are all known first-party uses rectified? |
Member
Author
|
@rainersigwald I have collected some usage data here: I think most of those are in-process instantiation so it will not be serialized for IPC and hence this change will not break them. Now when I think about it more, chance of this change to cause serious havoc is small. I have rephased NOTE |
Member
|
Can you run an experimental insertion and try out the build with C++ code analysis and FxCop? I would expect the custom errors to be created at build time and thus in the MSBuild.exe worker, not in devenv.exe.
|
JanKrivanek
added a commit
that referenced
this pull request
Oct 18, 2023
Experimental insertion for #9318
rokonec
force-pushed
the
rokonec/BinFmt-disabled-by-default
branch
from
88e03f4 to
c62c8f3
Compare
Member
|
All prerequisities merged in VS |
ladipro
approved these changes
Nov 20, 2023
Co-authored-by: Ladi Prosek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9300
Context
.NET Framework shall throw error when attempting to serialize customer event args by binfmt.
See #9300 for more context.
Changes Made
Testing
Local. Unit tests.
Notes
It is breaking change, but chance of break is small, IMO.