Removed tests containing TranslateDotNet#9017
Merged
maridematte merged 2 commits intodotnet:mainfrom Aug 9, 2023
Merged
Conversation
JanKrivanek
approved these changes
Jul 14, 2023
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
As discussed offline - it'd be nice to preserve ProjectEvaluationFinishedEventArgs_Tests and have them use the acutal production serialization code of ProjectEvaluationFinishedEventArgs within NodePackageMessageBase.
I do not consider it a blocker though as the test wasn't testing codepath that was used in prod anywas. (howevery very nice to have :-))
Other than that - looks good!
YuliiaKovalova
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8924
Context
We're removing BinaryFormatter from the codebase, as such tests that are not relevant needed to be deleted.
Changes Made