Fix crash in DOTNET_SYSTEM_GLOBALIZATION_INVARIANT mode#8738
Merged
JaynieBai merged 1 commit intodotnet:mainfrom May 10, 2023
Merged
Fix crash in DOTNET_SYSTEM_GLOBALIZATION_INVARIANT mode#8738JaynieBai merged 1 commit intodotnet:mainfrom
JaynieBai merged 1 commit intodotnet:mainfrom
Conversation
…s enabled and console codepage, not ANSI.
Member
JanKrivanek
approved these changes
May 9, 2023
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good to me - thanks!
rainersigwald
approved these changes
May 9, 2023
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I do not remember all the subtleties here but this looks like it's good to me.
Member
JanKrivanek
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
If DOTNET_SYSTEM_GLOBALIZATION_INVARIANT is enabled and console codepage non-ANSI MSBuild will crash on an attempt to create CultureInfo:
Changes Made
Keep the current thread culture the same if CurrentUICulture is Invariant.