Make target items paths crossplatform#8277
Merged
JanKrivanek merged 2 commits intodotnet:mainfrom Jan 4, 2023
Merged
Conversation
Forgind
approved these changes
Jan 3, 2023
JaynieBai
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8188
Context
Items Exclusion filtering for items defined within targets is not using same filtering logic (https://github.com/dotnet/msbuild/blob/main/src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs#L483-L486) as items defined outside of targets (https://github.com/dotnet/msbuild/blob/main/src/Build/Evaluation/LazyItemEvaluator.IncludeOperation.cs#L89-L93). There is a discrepancy in cross-platform paths mix-matchingh.
Changes Made
Rather targeted isolated change the build time exclusion evaluation (for items defined within targets) is comparing on normalized paths.
It's a question whether we rather do not want to try to extract and unify the items expansion logic - that might however be a large spanning change with notrivial regression risk.
Testing
Targetted unit test added ilustrating the issue.