[main] Update dependencies from dotnet/roslyn#8236
Merged
Conversation
Member
|
@ladipro do you by chance see an easy way out of this? |
Member
Member
|
@rainersigwald looks good, I was just going to reply with a similar fix. Thank you! |
…208.26 Microsoft.Net.Compilers.Toolset From Version 4.4.0-2.22458.3 -> To Version 4.5.0-2.22608.26
This triggered some C# compiler errors with newer versions of the compiler: ``` S:\msbuild\src\StringTools\InternableString.Simple.cs(130,39): error CS8170: Struct members cannot return 'this' or other instance members by reference [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35] S:\msbuild\src\StringTools\InternableString.Simple.cs(130,20): error CS8347: Cannot use a result of 'InternableString.Enumerator.Enumerator(ref InternableString)' in this context because it may expose variables referenced by parameter 'spanBuilder' outside of their declaration scope [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35] ``` Since this implementation is purely for the MSBuildTaskHost net35 compatibility case and self-describes as "inefficient", I think it's ok to make it a regular non-ref struct.
rainersigwald
force-pushed
the
darc-main-9d164fc6-edbb-420c-b39b-c1cb5c595170
branch
from
a36e36b to
5cc5011
Compare
rainersigwald
approved these changes
Dec 16, 2022
rainersigwald
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn