Add dotnet/skills marketplace and enable plugins#13582
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Copilot agent configuration file to register additional plugin marketplaces and enable a set of dotnet-related plugins for this repo.
Changes:
- Add
.github/copilot/settings.jsondefining two extra marketplaces (dotnet/arcade-skills,dotnet/skills) - Enable
dotnet-dnceng,dotnet,dotnet-msbuild,dotnet-nuget, anddotnet-testplugins from those marketplaces
Show a summary per file
| File | Description |
|---|---|
.github/copilot/settings.json |
Registers dotnet plugin marketplaces and enables selected dotnet plugins for Copilot agents |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
JanKrivanek
approved these changes
Apr 21, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
24-Dimension Expert Review — .github/copilot/settings.json
PR #13582 adds a Copilot agent configuration file that registers two plugin marketplaces and enables 5 plugins. This is a purely additive, non-code configuration change.
Verification Performed
- ✅
dotnet/arcade-skills— confirmed official dotnet org repo, containsplugins/dotnet-dnceng - ✅
dotnet/skills— confirmed official dotnet org repo (1,341 ★), containsplugins/dotnet,plugins/dotnet-msbuild,plugins/dotnet-nuget,plugins/dotnet-test - ✅ JSON is well-formed
- ✅ PR references related work (#13574)
Dimension Summary
| # | Dimension | Verdict | Notes |
|---|---|---|---|
| 1 | Backwards Compatibility | ✅ LGTM | New file, purely additive |
| 2 | ChangeWave Discipline | ✅ LGTM | N/A — no engine behavioral change |
| 3 | Performance & Allocation | ✅ LGTM | N/A — no runtime code |
| 4 | Test Coverage | ✅ LGTM | N/A — config file, no testable behavior |
| 5 | Error Message Quality | ✅ LGTM | N/A — no error messages |
| 6 | Logging & Diagnostics | ✅ LGTM | N/A — no logging |
| 7 | String Comparison | ✅ LGTM | N/A — no C# code |
| 8 | API Surface | ✅ LGTM | N/A — no API changes |
| 9 | Target Authoring | ✅ LGTM | N/A — no targets |
| 10 | Design Before Implementation | ✅ LGTM | Simple config, well-scoped |
| 11 | Cross-Platform | ✅ LGTM | N/A — JSON file |
| 12 | Code Simplification | ✅ LGTM | N/A — no code |
| 13 | Concurrency | ✅ LGTM | N/A — no runtime code |
| 14 | Naming Precision | ✅ LGTM | Plugin names follow dotnet conventions |
| 15 | SDK Integration | ✅ LGTM | N/A — no SDK changes |
| 16 | Idiomatic C# Patterns | ✅ LGTM | N/A — no C# code |
| 17 | File I/O & Path Handling | ✅ LGTM | N/A — no file I/O |
| 18 | Documentation Accuracy | ✅ LGTM | Config file, no doc update needed |
| 19 | Build Infrastructure | ✅ LGTM | Does not affect build pipeline |
| 20 | Scope & PR Discipline | ✅ LGTM | Single focused change, references #13574 |
| 21 | Evaluation Model | ✅ LGTM | N/A — no evaluation changes |
| 22 | Correctness & Edge Cases | ✅ LGTM | All 5 plugin names verified to exist |
| 23 | Dependency Management | ✅ LGTM | References trusted dotnet org repos only |
| 24 | Security Awareness | ✅ LGTM | Both repos are official dotnet org, MIT-licensed |
Result: 24/24 dimensions clear. No issues found.
Generated by Expert Code Review (on open) for issue #13582 · ● 2.3M
jankratochvilcz
requested changes
Apr 21, 2026
jankratochvilcz
left a comment
jankratochvilcz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, let's discuss on the one comment and then merge!
JanProvaznik
approved these changes
Apr 21, 2026
ViktorHofer
approved these changes
Apr 21, 2026
Evangelink
commented
Apr 21, 2026
Member
Author
|
@jankratochvilcz done |
jankratochvilcz
approved these changes
Apr 21, 2026
jankratochvilcz
left a comment
jankratochvilcz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, approving!
This was referenced Apr 21, 2026
This was referenced Jun 10, 2026
This was referenced Jun 26, 2026
github-actions Bot
pushed a commit
to IntelliTect/Multitool
that referenced
this pull request
Jun 29, 2026
Updated [Microsoft.Build](https://github.com/dotnet/msbuild) from 18.6.3 to 18.7.1. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Build's releases](https://github.com/dotnet/msbuild/releases)._ ## 18.7.1 ## What's Changed * Fix TraceEngine file contention deadlock in multithreaded mode by @JanProvaznik in dotnet/msbuild#13446 * Remove duplicate test cases in MultithreadableTaskAnalyzer by @Youssef1313 in dotnet/msbuild#13483 * Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test project by @Youssef1313 in dotnet/msbuild#13481 * Fix MSBuildTask0002 analyzer warnings in already-migrated tasks by @JanProvaznik in dotnet/msbuild#13466 * Fix race conditions in task host path resolution by @AR-May in dotnet/msbuild#13485 * Migrate ToolTask and Al task to TaskEnvironment API by @OvesN in dotnet/msbuild#13423 * Bump main to 18.7, add vs18.6 to merge flow by @MichalPavlik in dotnet/msbuild#13472 * Avoid allocations in GetHashCode implementations by @DustinCampbell in dotnet/msbuild#13475 * Add PATs rotation to agentic workflow(s) by @JanKrivanek in dotnet/msbuild#13496 * Fix ASP.NET WebSite projects to copy netstandard.dll facade when required by @JanProvaznik in dotnet/msbuild#13058 * Migrate AspNetCompiler to TaskEnvironment API by @OvesN in dotnet/msbuild#13424 * Add review workflow by @JanKrivanek in dotnet/msbuild#13503 * Strengthen reviewer skill: add step-back analysis dimensions by @JanProvaznik in dotnet/msbuild#13504 * Add 'Request Speedometer Perf Run' to VS experimental insertion build policies by @Copilot in dotnet/msbuild#13505 * Remove duplicate @ prefix from issueAuthor in GitOps by @akoeplinger in dotnet/msbuild#13492 * Improve review aw by @JanKrivanek in dotnet/msbuild#13510 * Migrates unit tests to use RoslynCodeTaskFactory to enable running tests under .NET Core by @jankratochvilcz in dotnet/msbuild#13500 * Fix cross-AppDomain TaskItem modifier cache regression by @DustinCampbell in dotnet/msbuild#13493 * Discourage review agent from approving PRs by @JanKrivanek in dotnet/msbuild#13512 * Stop trying to deploy ValueTuple by @rainersigwald in dotnet/msbuild#13507 * Ad-hoc re-sign bootstrap dotnet on macOS to prevent SIGKILL by @jankratochvilcz in dotnet/msbuild#13513 * RoslynCodeTaskFactory: Log MSB3753 when task class does not implement ITask by @jankratochvilcz in dotnet/msbuild#13517 * Update gh-aw (upon mcp policy changes) by @JanKrivanek in dotnet/msbuild#13526 * Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents by @nareshjo in dotnet/msbuild#13509 * Fix telemetry allocation regression: per-engine collector ownership by @JanProvaznik in dotnet/msbuild#13516 * Migrate to xunit.v3 by @Youssef1313 in dotnet/msbuild#13482 * Fix stray brace in HandleBuildCancel trace string causing MSB1025 by @Copilot in dotnet/msbuild#13535 * Bumping to 10.0.4 runtime packages by @MichalPavlik in dotnet/msbuild#13533 * Remove early return in GetCanonicalForm, always call System.IO.Path by @OvesN in dotnet/msbuild#13532 * Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new… by @snechaev in dotnet/msbuild#13474 * Migrate GetReferenceAssemblyPaths task to TaskEnvironment API by @OvesN in dotnet/msbuild#13495 * Stabilize ToolTaskThatTimeoutAndRetry test by @rainersigwald in dotnet/msbuild#13489 * [automated] Merge branch 'vs18.6' => 'main' by @github-actions[bot] in dotnet/msbuild#13506 * Add extra test assertions around tests by @Youssef1313 in dotnet/msbuild#13536 * Add static eval for repo skills/agents via skill-validator by @JanKrivanek in dotnet/msbuild#13537 * Migrate SGen task to Task environment API by @OvesN in dotnet/msbuild#13457 * Fix TerminalLogger assert failure for metaproj files and cached project eval ID by @OvesN in dotnet/msbuild#13480 * Filter out approving review from pr-reviewer agent by @JanKrivanek in dotnet/msbuild#13553 * Use a unique task name per invocation to tabilize RoslynCodeTaskFactory_ReuseCompilation test by @huulinhnguyen-dev in dotnet/msbuild#13551 * Brief doc on feedback/logging/data systems by @rainersigwald in dotnet/msbuild#13554 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13881982 by @dotnet-bot in dotnet/msbuild#13437 * Stage 3: Forward BuildProjectFile* callbacks from OOP TaskHost to worker node by @JanProvaznik in dotnet/msbuild#13350 * Enable TaskHost Callbacks by default by @JanProvaznik in dotnet/msbuild#13579 * Remove unactionable info from reviewer agent by @JanKrivanek in dotnet/msbuild#13578 * Enlighten RequiresFramework35SP1Assembly task for multithreaded mode by @jankratochvilcz in dotnet/msbuild#13575 * Make SdkResolver-provided environment variables take precedence over ambient environment by @Copilot in dotnet/msbuild#12655 * Add dotnet/skills marketplace and enable plugins by @Evangelink in dotnet/msbuild#13582 * The skills/agents check filters-in only touched files by @JanKrivanek in dotnet/msbuild#13586 * Fix skill-validation workflow failing when agents directory is deleted by @JeremyKuhne in dotnet/msbuild#13592 ... (truncated) Commits viewable in [compare view](dotnet/msbuild@v18.6.3...v18.7.1). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.github/copilot/settings.jsonto configure Copilot agent plugin marketplaces and enable dotnet plugins:dotnet/arcade-skillsmarketplace withdotnet-dncengplugindotnet/skillsmarketplace withdotnet,dotnet-msbuild,dotnet-nuget, anddotnet-testpluginsRelates to (and should replace a big part of) #13574