Skip to content

Improve review aw#13510

Merged
JanKrivanek merged 5 commits into
dotnet:mainfrom
JanKrivanek:dev/jankrivanek/improve-review-aw-trigger
Apr 9, 2026
Merged

Improve review aw#13510
JanKrivanek merged 5 commits into
dotnet:mainfrom
JanKrivanek:dev/jankrivanek/improve-review-aw-trigger

Conversation

@JanKrivanek

@JanKrivanek JanKrivanek commented Apr 9, 2026

Copy link
Copy Markdown
Member

Context

followup of #13503

Improvements:

  • let the workflow autotrigger even for fork PRs - from the users with >= contributor permissions to the repo
  • allow posting code inlined comments as well
  • guide the agent to use the gh-aw dedicated tools if available

Note:

Add create-pull-request-review-comment and submit-pull-request-review
safe-outputs so the reviewer agent posts findings as inline diff comments
(tied to specific file+line) rather than general PR comments. Update
expert-reviewer Wave 3/4 instructions to use the correct tools.

Also adds forks and roles support from previous commit.
@JanKrivanek JanKrivanek requested a review from a team as a code owner April 9, 2026 05:48
Copilot AI review requested due to automatic review settings April 9, 2026 05:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up to the initial “expert review” workflow integration, expanding it to (1) auto-trigger in more PR scenarios (incl. forks gated by repo roles) and (2) let the reviewer agent post proper inline PR review comments + a final review verdict via gh-aw safe-output tools.

Changes:

  • Add role-gating (admin, maintainer, write) to the slash-command and on-open workflows, and allow fork PRs for the on-open trigger.
  • Extend safe-output tooling to support inline PR review comments and submitting a final PR review (verdict).
  • Update the expert-reviewer agent instructions to prefer gh-aw safe-output tools when available.
Show a summary per file
File Description
.github/workflows/shared/review-shared.md Expands safe-outputs and updates workflow prompt guidance to use inline review comments + final review submission.
.github/workflows/review.agent.md Adds role gating for /review slash-command workflow.
.github/workflows/review.agent.lock.yml Regenerates compiled workflow to include new safe-output tools + role gating wiring.
.github/workflows/review-on-open.agent.md Allows fork PRs and adds explicit role gating for auto-run on PR open/ready.
.github/workflows/review-on-open.agent.lock.yml Regenerates compiled workflow to reflect fork allowance + new safe-output tools + role gating.
.github/agents/expert-reviewer.md Updates posting guidance to use gh-aw safe-output tools and adds a “tool availability” note.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 2

Comment thread .github/workflows/review-on-open.agent.md Outdated
Comment thread .github/agents/expert-reviewer.md
@JanKrivanek JanKrivanek marked this pull request as draft April 9, 2026 05:54
pull_request from forks does not have access to repo secrets, causing
the activation job to fail at COPILOT_GITHUB_TOKEN validation.

Switch to pull_request_target which runs in the base repo context with
full secret access. This is safe because:
- The agent reads diffs via GitHub MCP tools, not by executing PR code
- roles: [admin, maintainer, write] restricts to trusted contributors
- Checkout is only for .github and .agents folders from the base branch

Also drops ready_for_review type (not supported by gh-aw compiler for
pull_request_target). Draft-to-ready PRs can use /review command.

Addresses Copilot review comment about misleading roles comment.
@JanKrivanek JanKrivanek marked this pull request as ready for review April 9, 2026 07:41
@JanKrivanek JanKrivanek closed this Apr 9, 2026
@JanKrivanek JanKrivanek reopened this Apr 9, 2026
@JanKrivanek JanKrivanek enabled auto-merge April 9, 2026 07:41
@JanKrivanek JanKrivanek merged commit 3f8df22 into dotnet:main Apr 9, 2026
10 checks passed
github-actions Bot pushed a commit to IntelliTect/Multitool that referenced this pull request Jun 29, 2026
Updated [Microsoft.Build](https://github.com/dotnet/msbuild) from 18.6.3
to 18.7.1.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.Build's
releases](https://github.com/dotnet/msbuild/releases)._

## 18.7.1

## What's Changed
* Fix TraceEngine file contention deadlock in multithreaded mode by
@​JanProvaznik in dotnet/msbuild#13446
* Remove duplicate test cases in MultithreadableTaskAnalyzer by
@​Youssef1313 in dotnet/msbuild#13483
* Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test
project by @​Youssef1313 in dotnet/msbuild#13481
* Fix MSBuildTask0002 analyzer warnings in already-migrated tasks by
@​JanProvaznik in dotnet/msbuild#13466
* Fix race conditions in task host path resolution by @​AR-May in
dotnet/msbuild#13485
* Migrate ToolTask and Al task to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13423
* Bump main to 18.7, add vs18.6 to merge flow by @​MichalPavlik in
dotnet/msbuild#13472
* Avoid allocations in GetHashCode implementations by @​DustinCampbell
in dotnet/msbuild#13475
* Add PATs rotation to agentic workflow(s) by @​JanKrivanek in
dotnet/msbuild#13496
* Fix ASP.NET WebSite projects to copy netstandard.dll facade when
required by @​JanProvaznik in
dotnet/msbuild#13058
* Migrate AspNetCompiler to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13424
* Add review workflow by @​JanKrivanek in
dotnet/msbuild#13503
* Strengthen reviewer skill: add step-back analysis dimensions by
@​JanProvaznik in dotnet/msbuild#13504
* Add 'Request Speedometer Perf Run' to VS experimental insertion build
policies by @​Copilot in dotnet/msbuild#13505
* Remove duplicate @ prefix from issueAuthor in GitOps by @​akoeplinger
in dotnet/msbuild#13492
* Improve review aw by @​JanKrivanek in
dotnet/msbuild#13510
* Migrates unit tests to use RoslynCodeTaskFactory to enable running
tests under .NET Core by @​jankratochvilcz in
dotnet/msbuild#13500
* Fix cross-AppDomain TaskItem modifier cache regression by
@​DustinCampbell in dotnet/msbuild#13493
* Discourage review agent from approving PRs by @​JanKrivanek in
dotnet/msbuild#13512
* Stop trying to deploy ValueTuple by @​rainersigwald in
dotnet/msbuild#13507
* Ad-hoc re-sign bootstrap dotnet on macOS to prevent SIGKILL by
@​jankratochvilcz in dotnet/msbuild#13513
* RoslynCodeTaskFactory: Log MSB3753 when task class does not implement
ITask by @​jankratochvilcz in
dotnet/msbuild#13517
* Update gh-aw (upon mcp policy changes) by @​JanKrivanek in
dotnet/msbuild#13526
* Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents by
@​nareshjo in dotnet/msbuild#13509
* Fix telemetry allocation regression: per-engine collector ownership by
@​JanProvaznik in dotnet/msbuild#13516
* Migrate to xunit.v3 by @​Youssef1313 in
dotnet/msbuild#13482
* Fix stray brace in HandleBuildCancel trace string causing MSB1025 by
@​Copilot in dotnet/msbuild#13535
* Bumping to 10.0.4 runtime packages by @​MichalPavlik in
dotnet/msbuild#13533
* Remove early return in GetCanonicalForm, always call System.IO.Path by
@​OvesN in dotnet/msbuild#13532
* Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new…
by @​snechaev in dotnet/msbuild#13474
* Migrate GetReferenceAssemblyPaths task to TaskEnvironment API by
@​OvesN in dotnet/msbuild#13495
* Stabilize ToolTaskThatTimeoutAndRetry test by @​rainersigwald in
dotnet/msbuild#13489
* [automated] Merge branch 'vs18.6' => 'main' by @​github-actions[bot]
in dotnet/msbuild#13506
* Add extra test assertions around tests by @​Youssef1313 in
dotnet/msbuild#13536
* Add static eval for repo skills/agents via skill-validator by
@​JanKrivanek in dotnet/msbuild#13537
* Migrate SGen task to Task environment API by @​OvesN in
dotnet/msbuild#13457
* Fix TerminalLogger assert failure for metaproj files and cached
project eval ID by @​OvesN in
dotnet/msbuild#13480
* Filter out approving review from pr-reviewer agent by @​JanKrivanek in
dotnet/msbuild#13553
* Use a unique task name per invocation to tabilize
RoslynCodeTaskFactory_ReuseCompilation test by @​huulinhnguyen-dev in
dotnet/msbuild#13551
* Brief doc on feedback/logging/data systems by @​rainersigwald in
dotnet/msbuild#13554
* Localized file check-in by OneLocBuild Task: Build definition ID 9434:
Build ID 13881982 by @​dotnet-bot in
dotnet/msbuild#13437
* Stage 3: Forward BuildProjectFile* callbacks from OOP TaskHost to
worker node by @​JanProvaznik in
dotnet/msbuild#13350
* Enable TaskHost Callbacks by default by @​JanProvaznik in
dotnet/msbuild#13579
* Remove unactionable info from reviewer agent by @​JanKrivanek in
dotnet/msbuild#13578
* Enlighten RequiresFramework35SP1Assembly task for multithreaded mode
by @​jankratochvilcz in dotnet/msbuild#13575
* Make SdkResolver-provided environment variables take precedence over
ambient environment by @​Copilot in
dotnet/msbuild#12655
* Add dotnet/skills marketplace and enable plugins by @​Evangelink in
dotnet/msbuild#13582
* The skills/agents check filters-in only touched files by @​JanKrivanek
in dotnet/msbuild#13586
* Fix skill-validation workflow failing when agents directory is deleted
by @​JeremyKuhne in dotnet/msbuild#13592
 ... (truncated)

Commits viewable in [compare
view](dotnet/msbuild@v18.6.3...v18.7.1).
</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants