Skip to content

Add 'Request Speedometer Perf Run' to VS experimental insertion build policies#13505

Merged
JanProvaznik merged 2 commits into
mainfrom
copilot/update-insertion-build-policies
Apr 8, 2026
Merged

Add 'Request Speedometer Perf Run' to VS experimental insertion build policies#13505
JanProvaznik merged 2 commits into
mainfrom
copilot/update-insertion-build-policies

Conversation

Copilot AI commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Adds the Request Speedometer Perf Run policy to the experimental VS insertion pipeline alongside the existing Request Perf DDRITs policy.

Context

The experimental insertion was missing the Speedometer perf run policy, meaning that performance gate was not being triggered on experimental insertions.

Changes Made

  • azure-pipelines/vs-insertion-experimental.yml: Added Request Speedometer Perf Run to InsertionBuildPolicies (comma-separated, matching the multi-policy format)
InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

Testing

Pipeline configuration change only — no code logic affected.

Notes

The regular (non-experimental) insertion pipeline should be checked to ensure parity if needed.

Original prompt

In azure-pipelines/vs-insertion-experimental.yml at line 158, the InsertionBuildPolicies currently only includes 'Request Perf DDRITs'.

Update line 158 to also include the 'Request Speedometer Perf Run' policy. The updated line should be:

            InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

This is the same format used for multiple policies — comma-separated within a single quoted string.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: InsertionBuildPolicies: 'Request Perf DDRITs'
also add policy 'Request Speedometer Perf Run'

Assistant:

Let me first look at the current file to understand the context around line 158.

Assistant: I can see the file. Line 158 currently has InsertionBuildPolicies: 'Request Perf DDRITs' and you'd like to also add 'Request Speedometer Perf Run'. Let me create a PR for this change.

Assistant: I've kicked off the Copilot coding agent to create a pull request that adds 'Request Speedometer Perf Run' to the InsertionBuildPolicies on line 158 of azure-pipelines/vs-insertion-experimental.yml. The updated line will be:

            InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

You'll receive a notification once the PR is ready for review.

This pull request was created from Copilot chat.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo.

@JanProvaznik JanProvaznik requested a review from a team April 8, 2026 12:13
Copilot AI changed the title [WIP] Update InsertionBuildPolicies to include Speedometer Perf Run Add 'Request Speedometer Perf Run' to VS experimental insertion build policies Apr 8, 2026
Copilot AI requested a review from JanProvaznik April 8, 2026 12:14
@JanProvaznik JanProvaznik marked this pull request as ready for review April 8, 2026 13:24
Copilot AI review requested due to automatic review settings April 8, 2026 13:24
@JanProvaznik JanProvaznik enabled auto-merge (squash) April 8, 2026 13:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing Speedometer performance gate to the experimental VS insertion pipeline so experimental insertions trigger the same additional perf policy intended for insertions.

Changes:

  • Updates the experimental VS insertion pipeline to request both DDRIT perf runs and Speedometer perf runs via InsertionBuildPolicies.

@JanProvaznik JanProvaznik merged commit cbe2bab into main Apr 8, 2026
14 checks passed
@JanProvaznik JanProvaznik deleted the copilot/update-insertion-build-policies branch April 8, 2026 16:10
dfederm pushed a commit to dfederm/msbuild that referenced this pull request Apr 9, 2026
… policies (dotnet#13505)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: JanProvaznik <[email protected]>
github-actions Bot pushed a commit to IntelliTect/Multitool that referenced this pull request Jun 29, 2026
Updated [Microsoft.Build](https://github.com/dotnet/msbuild) from 18.6.3
to 18.7.1.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.Build's
releases](https://github.com/dotnet/msbuild/releases)._

## 18.7.1

## What's Changed
* Fix TraceEngine file contention deadlock in multithreaded mode by
@​JanProvaznik in dotnet/msbuild#13446
* Remove duplicate test cases in MultithreadableTaskAnalyzer by
@​Youssef1313 in dotnet/msbuild#13483
* Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test
project by @​Youssef1313 in dotnet/msbuild#13481
* Fix MSBuildTask0002 analyzer warnings in already-migrated tasks by
@​JanProvaznik in dotnet/msbuild#13466
* Fix race conditions in task host path resolution by @​AR-May in
dotnet/msbuild#13485
* Migrate ToolTask and Al task to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13423
* Bump main to 18.7, add vs18.6 to merge flow by @​MichalPavlik in
dotnet/msbuild#13472
* Avoid allocations in GetHashCode implementations by @​DustinCampbell
in dotnet/msbuild#13475
* Add PATs rotation to agentic workflow(s) by @​JanKrivanek in
dotnet/msbuild#13496
* Fix ASP.NET WebSite projects to copy netstandard.dll facade when
required by @​JanProvaznik in
dotnet/msbuild#13058
* Migrate AspNetCompiler to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13424
* Add review workflow by @​JanKrivanek in
dotnet/msbuild#13503
* Strengthen reviewer skill: add step-back analysis dimensions by
@​JanProvaznik in dotnet/msbuild#13504
* Add 'Request Speedometer Perf Run' to VS experimental insertion build
policies by @​Copilot in dotnet/msbuild#13505
* Remove duplicate @ prefix from issueAuthor in GitOps by @​akoeplinger
in dotnet/msbuild#13492
* Improve review aw by @​JanKrivanek in
dotnet/msbuild#13510
* Migrates unit tests to use RoslynCodeTaskFactory to enable running
tests under .NET Core by @​jankratochvilcz in
dotnet/msbuild#13500
* Fix cross-AppDomain TaskItem modifier cache regression by
@​DustinCampbell in dotnet/msbuild#13493
* Discourage review agent from approving PRs by @​JanKrivanek in
dotnet/msbuild#13512
* Stop trying to deploy ValueTuple by @​rainersigwald in
dotnet/msbuild#13507
* Ad-hoc re-sign bootstrap dotnet on macOS to prevent SIGKILL by
@​jankratochvilcz in dotnet/msbuild#13513
* RoslynCodeTaskFactory: Log MSB3753 when task class does not implement
ITask by @​jankratochvilcz in
dotnet/msbuild#13517
* Update gh-aw (upon mcp policy changes) by @​JanKrivanek in
dotnet/msbuild#13526
* Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents by
@​nareshjo in dotnet/msbuild#13509
* Fix telemetry allocation regression: per-engine collector ownership by
@​JanProvaznik in dotnet/msbuild#13516
* Migrate to xunit.v3 by @​Youssef1313 in
dotnet/msbuild#13482
* Fix stray brace in HandleBuildCancel trace string causing MSB1025 by
@​Copilot in dotnet/msbuild#13535
* Bumping to 10.0.4 runtime packages by @​MichalPavlik in
dotnet/msbuild#13533
* Remove early return in GetCanonicalForm, always call System.IO.Path by
@​OvesN in dotnet/msbuild#13532
* Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new…
by @​snechaev in dotnet/msbuild#13474
* Migrate GetReferenceAssemblyPaths task to TaskEnvironment API by
@​OvesN in dotnet/msbuild#13495
* Stabilize ToolTaskThatTimeoutAndRetry test by @​rainersigwald in
dotnet/msbuild#13489
* [automated] Merge branch 'vs18.6' => 'main' by @​github-actions[bot]
in dotnet/msbuild#13506
* Add extra test assertions around tests by @​Youssef1313 in
dotnet/msbuild#13536
* Add static eval for repo skills/agents via skill-validator by
@​JanKrivanek in dotnet/msbuild#13537
* Migrate SGen task to Task environment API by @​OvesN in
dotnet/msbuild#13457
* Fix TerminalLogger assert failure for metaproj files and cached
project eval ID by @​OvesN in
dotnet/msbuild#13480
* Filter out approving review from pr-reviewer agent by @​JanKrivanek in
dotnet/msbuild#13553
* Use a unique task name per invocation to tabilize
RoslynCodeTaskFactory_ReuseCompilation test by @​huulinhnguyen-dev in
dotnet/msbuild#13551
* Brief doc on feedback/logging/data systems by @​rainersigwald in
dotnet/msbuild#13554
* Localized file check-in by OneLocBuild Task: Build definition ID 9434:
Build ID 13881982 by @​dotnet-bot in
dotnet/msbuild#13437
* Stage 3: Forward BuildProjectFile* callbacks from OOP TaskHost to
worker node by @​JanProvaznik in
dotnet/msbuild#13350
* Enable TaskHost Callbacks by default by @​JanProvaznik in
dotnet/msbuild#13579
* Remove unactionable info from reviewer agent by @​JanKrivanek in
dotnet/msbuild#13578
* Enlighten RequiresFramework35SP1Assembly task for multithreaded mode
by @​jankratochvilcz in dotnet/msbuild#13575
* Make SdkResolver-provided environment variables take precedence over
ambient environment by @​Copilot in
dotnet/msbuild#12655
* Add dotnet/skills marketplace and enable plugins by @​Evangelink in
dotnet/msbuild#13582
* The skills/agents check filters-in only touched files by @​JanKrivanek
in dotnet/msbuild#13586
* Fix skill-validation workflow failing when agents directory is deleted
by @​JeremyKuhne in dotnet/msbuild#13592
 ... (truncated)

Commits viewable in [compare
view](dotnet/msbuild@v18.6.3...v18.7.1).
</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants