Skip to content

Migrate GetReferenceAssemblyPaths task to TaskEnvironment API#13495

Merged
OvesN merged 7 commits into
dotnet:mainfrom
OvesN:dev/veronikao/dev/veronikao/migrate-GetReferenceAssemblyPaths-task-to-Task-Environment-API
Apr 14, 2026
Merged

Migrate GetReferenceAssemblyPaths task to TaskEnvironment API#13495
OvesN merged 7 commits into
dotnet:mainfrom
OvesN:dev/veronikao/dev/veronikao/migrate-GetReferenceAssemblyPaths-task-to-Task-Environment-API

Conversation

@OvesN

@OvesN OvesN commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #13494

Context

The GetReferenceAssemblyPaths task was made thread-safe for multithreaded MSBuild execution.

Changes Made

GetReferenceAssemblyPaths.cs

  • Replaced static bool? s_net35SP1SentinelAssemblyFound with static readonly Lazy<bool> using LazyThreadSafetyMode.PublicationOnly to ensure thread-safe initialization while preserving retry-on-failure behavior.
  • Routed path resolution through TaskEnvironment.GetAbsolutePath().

Testing

GetReferencePaths_Tests.cs

  • TestRelativeRootPathProducesSameResultAsAbsolute — runs the task twice (once with an absolute RootPath, once with a relative RootPath resolved via TaskEnvironment) and asserts identical output, validating that the TaskEnvironment.GetAbsolutePath() integration preserves behavior.
  • TestRelativeFallbackSearchPathProducesSameResultAsAbsolute — same pattern for TargetFrameworkFallbackSearchPaths: verifies a relative fallback path resolved via TaskEnvironment produces the same result as the equivalent absolute path.

@OvesN OvesN self-assigned this Apr 7, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 08:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the built-in GetReferenceAssemblyPaths task to the TaskEnvironment API to support correct path resolution under multithreaded MSBuild execution, and updates internal caching to be thread-safe.

Changes:

  • Mark GetReferenceAssemblyPaths as multithreadable and route relative path resolution through TaskEnvironment.GetAbsolutePath.
  • Replace a non-thread-safe static cache (bool?) with a thread-safe Lazy<bool> for the .NET 3.5 SP1 sentinel GAC lookup.
  • Add unit tests validating relative vs absolute behavior for RootPath and TargetFrameworkFallbackSearchPaths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Tasks/GetReferenceAssemblyPaths.cs Adds TaskEnvironment integration, multithreadable task surface, and thread-safe sentinel caching.
src/Tasks.UnitTests/GetReferencePaths_Tests.cs Adds regressions to ensure relative inputs resolved via TaskEnvironment match absolute-input behavior.

Comment thread src/Tasks/GetReferenceAssemblyPaths.cs
Comment thread src/Tasks.UnitTests/GetReferencePaths_Tests.cs Outdated
Comment thread src/Tasks.UnitTests/GetReferencePaths_Tests.cs Outdated
OvesN and others added 2 commits April 8, 2026 08:40
@OvesN OvesN requested review from JanProvaznik and SimaTian April 8, 2026 07:20
OvesN and others added 2 commits April 8, 2026 13:29
…enceAssemblyPaths-task-to-Task-Environment-API
…enceAssemblyPaths-task-to-Task-Environment-API
@JanProvaznik

Copy link
Copy Markdown
Member

/review

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Expert Code Review (command) completed successfully!

…enceAssemblyPaths-task-to-Task-Environment-API
@OvesN OvesN enabled auto-merge (squash) April 14, 2026 09:05
Comment thread src/Tasks.UnitTests/GetReferencePaths_Tests.cs Outdated
github-actions Bot pushed a commit to IntelliTect/Multitool that referenced this pull request Jun 29, 2026
Updated [Microsoft.Build](https://github.com/dotnet/msbuild) from 18.6.3
to 18.7.1.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.Build's
releases](https://github.com/dotnet/msbuild/releases)._

## 18.7.1

## What's Changed
* Fix TraceEngine file contention deadlock in multithreaded mode by
@​JanProvaznik in dotnet/msbuild#13446
* Remove duplicate test cases in MultithreadableTaskAnalyzer by
@​Youssef1313 in dotnet/msbuild#13483
* Ensure ThreadSafeTaskAnalyzer.Tests is considered as a unit test
project by @​Youssef1313 in dotnet/msbuild#13481
* Fix MSBuildTask0002 analyzer warnings in already-migrated tasks by
@​JanProvaznik in dotnet/msbuild#13466
* Fix race conditions in task host path resolution by @​AR-May in
dotnet/msbuild#13485
* Migrate ToolTask and Al task to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13423
* Bump main to 18.7, add vs18.6 to merge flow by @​MichalPavlik in
dotnet/msbuild#13472
* Avoid allocations in GetHashCode implementations by @​DustinCampbell
in dotnet/msbuild#13475
* Add PATs rotation to agentic workflow(s) by @​JanKrivanek in
dotnet/msbuild#13496
* Fix ASP.NET WebSite projects to copy netstandard.dll facade when
required by @​JanProvaznik in
dotnet/msbuild#13058
* Migrate AspNetCompiler to TaskEnvironment API by @​OvesN in
dotnet/msbuild#13424
* Add review workflow by @​JanKrivanek in
dotnet/msbuild#13503
* Strengthen reviewer skill: add step-back analysis dimensions by
@​JanProvaznik in dotnet/msbuild#13504
* Add 'Request Speedometer Perf Run' to VS experimental insertion build
policies by @​Copilot in dotnet/msbuild#13505
* Remove duplicate @ prefix from issueAuthor in GitOps by @​akoeplinger
in dotnet/msbuild#13492
* Improve review aw by @​JanKrivanek in
dotnet/msbuild#13510
* Migrates unit tests to use RoslynCodeTaskFactory to enable running
tests under .NET Core by @​jankratochvilcz in
dotnet/msbuild#13500
* Fix cross-AppDomain TaskItem modifier cache regression by
@​DustinCampbell in dotnet/msbuild#13493
* Discourage review agent from approving PRs by @​JanKrivanek in
dotnet/msbuild#13512
* Stop trying to deploy ValueTuple by @​rainersigwald in
dotnet/msbuild#13507
* Ad-hoc re-sign bootstrap dotnet on macOS to prevent SIGKILL by
@​jankratochvilcz in dotnet/msbuild#13513
* RoslynCodeTaskFactory: Log MSB3753 when task class does not implement
ITask by @​jankratochvilcz in
dotnet/msbuild#13517
* Update gh-aw (upon mcp policy changes) by @​JanKrivanek in
dotnet/msbuild#13526
* Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents by
@​nareshjo in dotnet/msbuild#13509
* Fix telemetry allocation regression: per-engine collector ownership by
@​JanProvaznik in dotnet/msbuild#13516
* Migrate to xunit.v3 by @​Youssef1313 in
dotnet/msbuild#13482
* Fix stray brace in HandleBuildCancel trace string causing MSB1025 by
@​Copilot in dotnet/msbuild#13535
* Bumping to 10.0.4 runtime packages by @​MichalPavlik in
dotnet/msbuild#13533
* Remove early return in GetCanonicalForm, always call System.IO.Path by
@​OvesN in dotnet/msbuild#13532
* Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new…
by @​snechaev in dotnet/msbuild#13474
* Migrate GetReferenceAssemblyPaths task to TaskEnvironment API by
@​OvesN in dotnet/msbuild#13495
* Stabilize ToolTaskThatTimeoutAndRetry test by @​rainersigwald in
dotnet/msbuild#13489
* [automated] Merge branch 'vs18.6' => 'main' by @​github-actions[bot]
in dotnet/msbuild#13506
* Add extra test assertions around tests by @​Youssef1313 in
dotnet/msbuild#13536
* Add static eval for repo skills/agents via skill-validator by
@​JanKrivanek in dotnet/msbuild#13537
* Migrate SGen task to Task environment API by @​OvesN in
dotnet/msbuild#13457
* Fix TerminalLogger assert failure for metaproj files and cached
project eval ID by @​OvesN in
dotnet/msbuild#13480
* Filter out approving review from pr-reviewer agent by @​JanKrivanek in
dotnet/msbuild#13553
* Use a unique task name per invocation to tabilize
RoslynCodeTaskFactory_ReuseCompilation test by @​huulinhnguyen-dev in
dotnet/msbuild#13551
* Brief doc on feedback/logging/data systems by @​rainersigwald in
dotnet/msbuild#13554
* Localized file check-in by OneLocBuild Task: Build definition ID 9434:
Build ID 13881982 by @​dotnet-bot in
dotnet/msbuild#13437
* Stage 3: Forward BuildProjectFile* callbacks from OOP TaskHost to
worker node by @​JanProvaznik in
dotnet/msbuild#13350
* Enable TaskHost Callbacks by default by @​JanProvaznik in
dotnet/msbuild#13579
* Remove unactionable info from reviewer agent by @​JanKrivanek in
dotnet/msbuild#13578
* Enlighten RequiresFramework35SP1Assembly task for multithreaded mode
by @​jankratochvilcz in dotnet/msbuild#13575
* Make SdkResolver-provided environment variables take precedence over
ambient environment by @​Copilot in
dotnet/msbuild#12655
* Add dotnet/skills marketplace and enable plugins by @​Evangelink in
dotnet/msbuild#13582
* The skills/agents check filters-in only touched files by @​JanKrivanek
in dotnet/msbuild#13586
* Fix skill-validation workflow failing when agents directory is deleted
by @​JeremyKuhne in dotnet/msbuild#13592
 ... (truncated)

Commits viewable in [compare
view](dotnet/msbuild@v18.6.3...v18.7.1).
</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate GetReferenceAssemblyPaths to TaskEnvironment API

4 participants