Add hostservices translation support for clr 4 task host#13154
Merged
YuliiaKovalova merged 8 commits intomainfrom Feb 3, 2026
Merged
Add hostservices translation support for clr 4 task host#13154YuliiaKovalova merged 8 commits intomainfrom
YuliiaKovalova merged 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the limitation that HostServices/target metadata translation in the out-of-proc task host protocol only works for the .NET task host, enabling the same behavior for the CLR4 (.NET Framework) task host.
Changes:
- Update
TaskHostConfiguration.Translateto serialize/deserializeTargetName,ProjectFile, andHostServicesfor the CLR4 “version 0” protocol as well as packet version 2+. - Document special meanings of
ITranslator.NegotiatedPacketVersion, including the “0” (framework-to-framework) case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Shared/TaskHostConfiguration.cs | Enables HostServices/target metadata translation for CLR4 task host communication by treating negotiated version 0 as supporting these fields. |
| src/Framework/ITranslator.cs | Clarifies protocol/version semantics in documentation for NegotiatedPacketVersion, including special values 0/1/2+. |
Member
Author
MichalPavlik
approved these changes
Feb 2, 2026
JanProvaznik
pushed a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
Attempt 2 for dotnet#13089 In scope of dotnet#12753 support for translating HostServices in Out of Proc Task Host was added, but limited to NET task host. This change removes this limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt 2 for #13089
In scope of #12753 support for translating HostServices in Out of Proc Task Host was added, but limited to NET task host.
This change removes this limitation.