Limit extended flag usage to NET and CLR4 runtimes#13080
Merged
YuliiaKovalova merged 4 commits intomainfrom Jan 21, 2026
Merged
Limit extended flag usage to NET and CLR4 runtimes#13080YuliiaKovalova merged 4 commits intomainfrom
YuliiaKovalova merged 4 commits intomainfrom
Conversation
Refactor TryCreateExtendedHeaderType to clarify conditions for extended header support.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix an issue introduced in PR #13033 where extended header support was enabled for CLR4 task hosts, but inadvertently broke CLR2 task hosts used by C++ projects for Design-Time Builds. The change attempts to limit extended flag usage to .NET Core+ and CLR4 runtimes, excluding CLR2.
Changes:
- Modified
TryCreateExtendedHeaderTypemethod to explicitly check for NET or CLR4 flags before enabling extended headers - Added inline comment explaining that extended headers are supported by .NET Core+ and CLR4 but not CLR2
Co-authored-by: Copilot <[email protected]>
ViktorHofer
approved these changes
Jan 21, 2026
rainersigwald
approved these changes
Jan 21, 2026
johnazule
pushed a commit
to johnazule/msbuild
that referenced
this pull request
Jan 22, 2026
Fixes # VS insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullRequest/701704#1768990369 C++ projects use clr2 for DTB and this change dotnet#13033 causes issues since an extended flag support wasn't added to the legacy environment by design. --------- Co-authored-by: Copilot <[email protected]>
YuliiaKovalova
added a commit
that referenced
this pull request
Jan 22, 2026
This reverts commit 89201ec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
VS insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullRequest/701704#1768990369
C++ projects use clr2 for DTB and this change #13033 causes issues since an extended flag support wasn't added to the legacy environment by design.