Merged
Conversation
This reverts commit fe44b97.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts #12945, restoring assembly scanning functionality in the TypeLoader that was previously removed. The main purpose is to bring back support for scanning executable files and older CLR versions on .NET Framework.
Key Changes
- Restored scanning for both
.dlland.exefiles in assembly directories when creating MetadataLoadContext - Re-introduced .NET Framework-specific logic to include CLR 2.0 and 3.5 assemblies in the assembly resolver
- Added a helper method
AddAssembliesToDictionaryto handle assembly deduplication with configurable priority
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/TypeLoader.cs | Restored assembly scanning logic including .exe file scanning, CLR 2.0/3.5 support on .NET Framework, and added helper method for assembly deduplication |
| src/MSBuild/MSBuild.csproj | Added reference to FrameworkLocationHelper.cs which is required by the restored TypeLoader code to locate older .NET Framework versions |
ViktorHofer
approved these changes
Dec 29, 2025
This was referenced Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #12945
It's unrelated to the reported regression since the counter degrades even without my change: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullRequest/696870#1766395219