Resolves the test failure in CanShutdownServerProcess when setting capacity for the _nodeContexts dictionary#12961
Merged
YuliiaKovalova merged 1 commit intodotnet:mainfrom Dec 29, 2025
Conversation
…pacity for the _nodeContexts dictionary
YuliiaKovalova
approved these changes
Dec 29, 2025
This was referenced Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the test failure in CanShutdownServerProcess when setting capacity for the _nodeContexts dictionary #12187
Fixes #12187
Context
When attempting to set capacity for
_nodeContextsdictionary to improve performance, the testMSBuildServer_Tests.CanShutdownServerProcess(byBuildManager: True)failed due toNullReferenceExceptionwhen accessinghost.BuildParameters.MaxNodeCountwithout null-checking.Changes Made
host.BuildParametersbefore accessingMaxNodeCountMaxNodeCount > 0to avoid invalid capacity valuesEnvironment.ProcessorCountforconcurrencyLevelto optimize multi-threaded scenariosBuildParametersis null or invalidTesting
MSBuildServer_Tests.CanShutdownServerProcesspasses with bothbyBuildManager: TrueandFalseNotes
This change allows performance optimization through pre-allocated dictionary capacity while ensuring test stability and proper null handling.