Revert assembly-scan change#12945
Merged
rainersigwald merged 2 commits intodotnet:mainfrom Dec 15, 2025
Merged
Conversation
This reverts commit fd4375f.
…work tasks (CLR35 and CLR2) (dotnet#12823)" This reverts commit 2960e90.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts two previous changes related to assembly scanning and resolution that caused performance failures in Visual Studio insertion. The revert removes the lazy initialization of CLR 2.0/3.5 runtime assemblies and the support for .exe file resolution in legacy .NET Framework tasks.
Key Changes:
- Removed lazy initialization of
runtimeAssembliesCLR35_20and associated helper methods - Simplified
CreateMetadataLoadContextto only scan .dll files (removed .exe support) - Removed
FrameworkLocationHelper.csreference from MSBuild.csproj
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Shared/TypeLoader.cs | Reverted assembly resolution changes - removed CLR 2.0/3.5 lazy loading logic and .exe file scanning |
| src/MSBuild/MSBuild.csproj | Removed FrameworkLocationHelper.cs reference that was added for CLR 2.0/3.5 support |
baronfel
approved these changes
Dec 15, 2025
This was referenced Dec 16, 2025
YuliiaKovalova
added a commit
that referenced
this pull request
Dec 29, 2025
This reverts commit fe44b97.
YuliiaKovalova
added a commit
that referenced
this pull request
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not totally clear how, but this appears to have caused perf DDRIT failures on insertion to VS. Reverting to investigate later.