Remove GeneratedFilesOutputPath parameter from XamlPreCompile targets#12885
Conversation
|
Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: dsplaisted <[email protected]>
Co-authored-by: dsplaisted <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR removes the GeneratedFilesOutputPath parameter from the Csc task invocation in the XamlPreCompile target and updates the associated comment to document this intentional divergence from the CoreCompile target in Microsoft.CSharp.Core.targets.
Key changes:
- Removed
GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from Csc task in XamlPreCompile target - Updated comment to explicitly state that GeneratedFilesOutputPath is intentionally omitted
Co-authored-by: rainersigwald <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@rainersigwald any reason to not merge this? |
|
No, we should merge as soon as we have green perf ddrits again. |
rainersigwald
deleted the
copilot/remove-generatedfilesoutputpath-parameter
branch
Context
The XamlPreCompile targets in Microsoft.CSharp.CurrentVersion.targets and Microsoft.VisualBasic.CurrentVersion.targets were passing
GeneratedFilesOutputPathto the Csc and Vbc tasks, which is unnecessary for XAML pre-compilation scenarios.Changes Made
GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from the Csc task invocation in the XamlPreCompile target in Microsoft.CSharp.CurrentVersion.targetsGeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from the Vbc task invocation in the XamlPreCompile target in Microsoft.VisualBasic.CurrentVersion.targetsTesting
Notes
This intentionally diverges from the CoreCompile targets in Microsoft.CSharp.Core.targets and Microsoft.VisualBasic.Core.targets, which retain the GeneratedFilesOutputPath parameter. Both C# and VB implementations now have consistent changes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.