Enhance error handling in RunningObjectTable#12755
Merged
Merged
Conversation
Refactor error handling in GetObject method to provide detailed COM error information when retrieval fails.
Added unit tests for Running Object Table error handling and success scenarios.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling in the RunningObjectTable class by replacing a simple Marshal.ThrowExceptionForHR() call with a detailed error reporting mechanism that retrieves and displays COM error information from IErrorInfo when available.
Key changes:
- Added
ThrowComExceptionWithDetailsmethod to construct detailed error messages including HRESULT codes and IErrorInfo details - Introduced
IErrorInfoCOM interface definition andGetErrorInfoP/Invoke declaration - Added
SystemandSystem.Textusing directives to support the new functionality
Comments suppressed due to low confidence (1)
src/Build/Instance/RunningObjectTable.cs:116
- Generic catch clause.
catch
{
// If we can't get error info details, just continue with the basic code.
}
baronfel
approved these changes
Nov 12, 2025
This was referenced Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor error handling in GetObject method to provide detailed COM error information when retrieval fails.