Add missing IsUnitTestProject to StringTools.UnitTests.net35#12697
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the IsUnitTestProject property to the StringTools.UnitTests.net35.csproj file. The Arcade SDK typically sets this property automatically based on naming conventions, but this project's name doesn't match the expected pattern, requiring an explicit property declaration.
Key Changes
- Added
<IsUnitTestProject>true</IsUnitTestProject>to align with Arcade SDK test project requirements
Youssef1313
requested review from
JanProvaznik,
YuliiaKovalova and
rainersigwald
YuliiaKovalova
approved these changes
Oct 27, 2025
This was referenced Oct 27, 2025
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arcade sets this property by naming convention, which doesn't apply to this project.
See https://github.com/dotnet/arcade/blob/f11f9fc40850209eb01a890dabd5e7d7506c7b4e/src/Microsoft.DotNet.Arcade.Sdk/tools/Tests.props#L16
This project was previously not run in CI at all because of this.
This is from the latest build on main:
which makes sense based on the condition in https://github.com/dotnet/arcade/blob/f11f9fc40850209eb01a890dabd5e7d7506c7b4e/src/Microsoft.DotNet.Arcade.Sdk/tools/Tests.targets#L35
Additionally, this can easily be verified by looking at build artifact and noticing that there are no trx files for this project.
This also has an impact on signing the assembly:
msbuild/src/Directory.Build.targets
Lines 7 to 16 in 60fc61c
(as well as collecting code coverage)
In addition, any property conditions around
IsTestProjectneeds to be during targets. It's very early to do that in props, because the property can be altered by the project itself.