Fix bug with not passing scheduled node id to the task host task#12639
Merged
AR-May merged 1 commit intodotnet:mainfrom Oct 15, 2025
Merged
Fix bug with not passing scheduled node id to the task host task#12639AR-May merged 1 commit intodotnet:mainfrom
AR-May merged 1 commit intodotnet:mainfrom
Conversation
AR-May
requested review from
JanProvaznik,
Copilot and
surayya-MS
and removed request for
JanProvaznik and
Copilot
JanProvaznik
approved these changes
Oct 14, 2025
Member
|
Is there a test that can prevent regressions here? |
Member
Author
|
This part is not quite easy to cover with tests, I think. Will need to have an end-to-end test with multiple projects getting built, I think. Maybe folks have better ideas how to cover this with tests. @JanProvaznik and I noticed this bug on merge of main into my WIP PRs. This bug appeared mostly because three of us (@AR-May, @JanProvaznik, @surayya-MS) working and modifying the same file and the same function invocations there. |
Member
Author
|
We should add more /mt end-to-end tests, they should hopefully cover many problems that may appear. We do not have enough of them. I will create an issue for that. |
This was referenced Oct 16, 2025
This was referenced Feb 23, 2026
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There seem to be a merge bug introduced in #12577.
The scheduled node id should be passed to the
TaskHostTaskin both instances of the task creation.Changes Made
Testing
None